Changing to set for subjectKeyIds for uniqueness

[ianwatsonrh]

There is currently a situation where subjectKeyId appears twice in the slice due to different valid conditions being true for a single certificate.

This PR ensures the subjectKeyId is only iterated over once.

See https://bugzilla.redhat.com/show_bug.cgi?id=2118284 for issue

[openshift-ci]

Hi @ianwatsonrh. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rfredette for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Miciah]

/ok-to-test

[ianwatsonrh]

/retest-required

…

On 7 Mar 2023, at 22:22, openshift-ci[bot] ***@***.***> wrote:  @ianwatsonrh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests: Test name Commit Details Required Rerun command ci/prow/e2e-azure-ovn 70fb06a link false /test e2e-azure-ovn ci/prow/e2e-aws-operator 70fb06a link true /test e2e-aws-operator Full PR test history. Your PR dashboard. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

[ianwatsonrh]

/retest-required

[ianwatsonrh]

/retest-required

[ianwatsonrh]

/retest-required

[ianwatsonrh]

/retest-required

[ianwatsonrh]

/retest-required

[ianwatsonrh]

/retest-required

[ianwatsonrh]

/retest-required

[ianwatsonrh]

/retest-required

[ianwatsonrh]

/retest-required

[openshift-ci]

@ianwatsonrh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-ovn	70fb06a	link	false	/test e2e-azure-ovn
ci/prow/e2e-aws-operator	70fb06a	link	true	/test e2e-aws-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[candita]

Thank you for this contribution @ianwatsonrh. We are working on this separately, and PR openshift/router#447 for ocpbugs-6661 supercedes this
/close

[openshift-ci]

@candita: Closed this PR.

Details

In response to this:

Thank you for this contribution @ianwatsonrh. We are working on this separately, and PR openshift/router#447 for ocpbugs-6661 supercedes this
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.