OCPBUGS-4827: Add missing AWS permission for ListTagsForResources

[montaguethomas]

The defined CredentialsRequest is missing a required permission for the AWS "Provider.lookupZoneIDWithoutResourceTagging" method.

cluster-ingress-operator/pkg/dns/aws/dns.go

Lines 340 to 352 in d9d1a2b

	input := &route53.ListTagsForResourcesInput{
	ResourceIds: make([]*string, len(resp.HostedZones)),
	ResourceType: aws.String("hostedzone"),
	}
	for i, zone := range resp.HostedZones {
	zoneID, err := zoneIDFromResource(aws.StringValue(zone.Id))
	if err != nil {
	innerError = err
	return false
	}
	input.ResourceIds[i] = &zoneID
	}
	output, err := m.route53.ListTagsForResources(input)

[openshift-ci]

Hi @montaguethomas. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Miciah]

/retitle OCPBUGS-4827 Add missing AWS permission for ListTagsForResources

[Miciah]

/ok-to-test

[Miciah]

@montaguethomas, thanks for the PR! Ayush filed OCPBUGS-4827 for the issue, and I have linked the PR to the bug. Would you mind updating the commit message to add a reference to the bug report?

[openshift-ci-robot]

@montaguethomas: This pull request references Jira Issue OCPBUGS-4827, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.0) matches configured target version for branch (4.13.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The defined CredentialsRequest is missing a required permission for the AWS "Provider.lookupZoneIDWithoutResourceTagging" method.

cluster-ingress-operator/pkg/dns/aws/dns.go

Lines 340 to 352 in d9d1a2b

	input := &route53.ListTagsForResourcesInput{
	ResourceIds: make([]*string, len(resp.HostedZones)),
	ResourceType: aws.String("hostedzone"),
	}
	for i, zone := range resp.HostedZones {
	zoneID, err := zoneIDFromResource(aws.StringValue(zone.Id))
	if err != nil {
	innerError = err
	return false
	}
	input.ResourceIds[i] = &zoneID
	}
	output, err := m.route53.ListTagsForResources(input)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Miciah]

Also, you need to run make generate to update pkg/manifests/bindata.go (see the ci/prow/verify job failure).

[montaguethomas]

@Miciah sure thing. done.

[montaguethomas]

/retest

[frobware]

/lgtm

[montaguethomas]

/retest

[candita]

/assign @Miciah

[Miciah]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 560b2d3 and 2 for PR HEAD 30f18df in total

[frobware]

{  openshift cluster install failed with infrastructure setup} | {  openshift cluster install failed with infrastructure setup}
-- | --
{  openshift cluster install failed with infrastructure setup}

/retest

[montaguethomas]

/retest

[montaguethomas]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 8d2294d and 1 for PR HEAD 30f18df in total

[Miciah]

@montaguethomas, another recently merged PR has caused a merge conflict for this PR. Do you mind rebasing your PR? Resolving the conflict should just be a matter of regenerating pkg/manifests/bindata.go by rerunning make generate during the rebase. Let me know if that's unclear or if you would like me to rebase the PR for you.

[montaguethomas]

@Miciah rebased branch and ran generate again.

[montaguethomas]

/retest-required

[montaguethomas]

/retest-required

[montaguethomas]

/retest

[montaguethomas]

@Miciah @frobware looks like all tests are finally passing and no merge conflict.

[Miciah]

Thanks!
/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD e84f7f6 and 2 for PR HEAD 41879a1 in total

[montaguethomas]

/retest-required

[openshift-ci]

@montaguethomas: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-ovn-serial	30f18df	link	true	/test e2e-gcp-ovn-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[montaguethomas]

/retest-required

[montaguethomas]

Calling out that ci/prow/e2e-gcp-ovn-serial test doesn't exist as a check on this project.

[openshift-ci-robot]

@montaguethomas: All pull requests linked via external trackers have merged:

• openshift/cluster-ingress-operator#868

Jira Issue OCPBUGS-4827 has been moved to the MODIFIED state.

Details

In response to this:

The defined CredentialsRequest is missing a required permission for the AWS "Provider.lookupZoneIDWithoutResourceTagging" method.

cluster-ingress-operator/pkg/dns/aws/dns.go

Lines 340 to 352 in d9d1a2b

	input := &route53.ListTagsForResourcesInput{
	ResourceIds: make([]*string, len(resp.HostedZones)),
	ResourceType: aws.String("hostedzone"),
	}
	for i, zone := range resp.HostedZones {
	zoneID, err := zoneIDFromResource(aws.StringValue(zone.Id))
	if err != nil {
	innerError = err
	return false
	}
	input.ResourceIds[i] = &zoneID
	}
	output, err := m.route53.ListTagsForResources(input)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Miciah]

/cherry-pick release-4.12

[openshift-cherrypick-robot]

@Miciah: #868 failed to apply on top of branch "release-4.12":

Applying: OCPBUGS-4827 Add missing AWS permission for ListTagsForResources
Using index info to reconstruct a base tree...
M	pkg/manifests/bindata.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/manifests/bindata.go
CONFLICT (content): Merge conflict in pkg/manifests/bindata.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-4827 Add missing AWS permission for ListTagsForResources
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.