OCPBUGS-4759: Do not manage DNS for an ingresscontroller with domain mismatch in GCP #866

gcs278 · 2022-12-12T20:36:25Z

Do not manage DNS for an ingresscontroller with a domain that does not match the baseDomain of the cluster DNS config for GCP.

This had been previously done for AWS (#761), now expanding to GCP.

pkg/operator/controller/ingress/dns.go: Add GCP domain validation to manageDNSForDomain
pkg/operator/controller/ingress/dns_test.go: Add unit tests for manageDNSForDomain with GCP

openshift-ci-robot · 2022-12-12T20:36:29Z

@gcs278: This pull request references Jira Issue OCPBUGS-4759, which is invalid:

expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Do not manage DNS for an ingresscontroller with a domain that does not match the baseDomain of the cluster DNS config for GCP.

This had been previously done for AWS, now expanding to GCP.

pkg/operator/controller/ingress/dns.go: Add GCP domain validation to manageDNSForDomain

pkg/operator/controller/ingress/dns_test.go: Add unit tests for manageDNSForDomain with GCP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gcs278 · 2022-12-12T20:37:46Z

/hold
Waiting for confirmation GCP indeed can't create domains outside of it's cluster domain or does something weird like appending domains (like azure).

gcs278 · 2022-12-13T21:14:44Z

/unhold
I confirmed GCP doesn't do wacky things with mismatching DNS domains, like treating it as a subdomain.

gcs278 · 2022-12-13T21:15:18Z

/jira refresh

openshift-ci-robot · 2022-12-13T21:15:22Z

@gcs278: This pull request references Jira Issue OCPBUGS-4759, which is invalid:

expected the bug to target the "4.13.0" version, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gcs278 · 2022-12-13T21:17:27Z

/jira refresh

openshift-ci-robot · 2022-12-13T21:17:33Z

@gcs278: This pull request references Jira Issue OCPBUGS-4759, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

candita · 2022-12-14T22:23:44Z

/assign @frobware

gcs278 · 2022-12-21T20:17:19Z

/retest-required

gcs278 · 2022-12-22T14:12:13Z

/retest-required

gcs278 · 2023-01-03T14:36:33Z

/retest-required

openshift-ci-robot · 2023-01-11T17:29:32Z

@gcs278: This pull request references Jira Issue OCPBUGS-4759, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

Do not manage DNS for an ingresscontroller with a domain that does not match the baseDomain of the cluster DNS config for GCP.

This had been previously done for AWS (#761), now expanding to GCP.

pkg/operator/controller/ingress/dns.go: Add GCP domain validation to manageDNSForDomain

pkg/operator/controller/ingress/dns_test.go: Add unit tests for manageDNSForDomain with GCP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…n that does not match the baseDomain of the cluster DNS config for GCP This had been previously done for AWS, now expanding to GCP. - pkg/operator/controller/ingress/dns.go: Add GCP domain validation to manageDNSForDomain - pkg/operator/controller/ingress/dns_test.go: Add unit tests for manageDNSForDomain with GCP

frobware · 2023-01-11T18:28:16Z

/lgtm

Miciah · 2023-01-11T19:49:19Z

/approve

openshift-ci · 2023-01-11T19:49:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2023-01-11T21:44:07Z

/retest-required

Remaining retests: 0 against base HEAD 560b2d3 and 2 for PR HEAD cb8d9bb in total

gcs278 · 2023-01-12T17:18:50Z

/retest-required

candita · 2023-01-13T04:50:08Z

/test e2e-aws-ovn-serial
/test e2e-gcp-ovn

frobware · 2023-01-13T08:34:14Z

Looks like the AWS cluster did not get created sucessfully:


openshift cluster install failed with other errors
 
level=fatal msg=failed to fetch Terraform Variables: failed to fetch dependency of "Terraform Variables": failed to generate asset "Platform Provisioning Check": baseDomain: Invalid value: "origin-ci-int-aws.dev.rhcloud.com": the zone already has record sets for the domain of the cluster: [api.ci-op-di99mig1-52591.origin-ci-int-aws.dev.rhcloud.com

/test e2e-aws-ovn-serial

openshift-ci-robot · 2023-01-13T10:30:53Z

/retest-required

Remaining retests: 0 against base HEAD 8d2294d and 1 for PR HEAD cb8d9bb in total

openshift-ci · 2023-01-13T13:02:31Z

@gcs278: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-ovn-serial	`cb8d9bb`	link	true	`/test e2e-gcp-ovn-serial`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-01-13T15:50:52Z

/retest-required

Remaining retests: 0 against base HEAD dc49def and 0 for PR HEAD cb8d9bb in total

openshift-ci-robot · 2023-01-13T18:18:39Z

@gcs278: All pull requests linked via external trackers have merged:

openshift/cluster-ingress-operator#866

Jira Issue OCPBUGS-4759 has been moved to the MODIFIED state.

Details

In response to this:

Do not manage DNS for an ingresscontroller with a domain that does not match the baseDomain of the cluster DNS config for GCP.

This had been previously done for AWS (#761), now expanding to GCP.

pkg/operator/controller/ingress/dns.go: Add GCP domain validation to manageDNSForDomain

pkg/operator/controller/ingress/dns_test.go: Add unit tests for manageDNSForDomain with GCP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 12, 2022

openshift-ci bot requested review from frobware and rfredette December 12, 2022 20:37

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2022

openshift-ci bot assigned frobware Dec 14, 2022

openshift-ci bot requested a review from lihongan January 11, 2023 17:29

gcs278 force-pushed the gcp-dns-record-mismatching branch from c50865e to cb8d9bb Compare January 11, 2023 18:14

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2023

openshift-merge-robot merged commit fc69408 into openshift:master Jan 13, 2023

OCPBUGS-4759: Do not manage DNS for an ingresscontroller with domain mismatch in GCP #866

OCPBUGS-4759: Do not manage DNS for an ingresscontroller with domain mismatch in GCP #866

Uh oh!

Conversation

gcs278 commented Dec 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Dec 12, 2022

Uh oh!

gcs278 commented Dec 12, 2022

Uh oh!

gcs278 commented Dec 13, 2022

Uh oh!

gcs278 commented Dec 13, 2022

Uh oh!

openshift-ci-robot commented Dec 13, 2022

Uh oh!

gcs278 commented Dec 13, 2022

Uh oh!

openshift-ci-robot commented Dec 13, 2022

Uh oh!

candita commented Dec 14, 2022

Uh oh!

gcs278 commented Dec 21, 2022

Uh oh!

gcs278 commented Dec 22, 2022

Uh oh!

gcs278 commented Jan 3, 2023

Uh oh!

openshift-ci-robot commented Jan 11, 2023

Uh oh!

frobware commented Jan 11, 2023

Uh oh!

Miciah commented Jan 11, 2023

Uh oh!

openshift-ci bot commented Jan 11, 2023

Uh oh!

openshift-ci-robot commented Jan 11, 2023

Uh oh!

gcs278 commented Jan 12, 2023

Uh oh!

candita commented Jan 13, 2023

Uh oh!

frobware commented Jan 13, 2023

Uh oh!

openshift-ci-robot commented Jan 13, 2023

Uh oh!

openshift-ci bot commented Jan 13, 2023

Uh oh!

openshift-ci-robot commented Jan 13, 2023

Uh oh!

openshift-ci-robot commented Jan 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gcs278 commented Dec 12, 2022 •

edited

Loading