Skip to content

WIP: Use DNS clients from Azure SDK v2 #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
r4f4 wants to merge 4 commits into from
Closed

WIP: Use DNS clients from Azure SDK v2 #848

r4f4 wants to merge 4 commits into from

Conversation

@r4f4
Copy link
Contributor

@r4f4 r4f4 commented Oct 21, 2022

By using the new clients we can drop ADAL which is being deprecated.

I have done this as a continuation of #846, but it could also be seen as an alternative to it.

Marking as WIP while I figure out if it works with AzureStack.

r4f4 added 4 commits October 21, 2022 14:57
@r4f4
dns: azure: use azidentity with an adapter
b766480 
ADAL will be deprecated in Dec 2022. Let's move to azidentity with an
adapter so the new authentication can work the V1 clients.
@r4f4
dns: azure: vendor in changes
14e683d
@r4f4
dns: azure: use SDK v2 clients
4db1254 
The DNS v2 clients are now officially released. By using them we also
can drop ADAL, which is being deprecated in Dec 2022.
@r4f4
dns: azure: vendor in changes
7c2a844
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2022
@openshift-ci openshift-ci bot requested review from candita and rfredette October 21, 2022 16:28
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign frobware for approval by writing /assign @frobware in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@r4f4
Copy link
Contributor Author

r4f4 commented Oct 21, 2022

/test e2e-azurestack

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2022

@r4f4: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws-operator
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-upgrade
  • /test e2e-gcp-ovn-serial
  • /test images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-aws-ovn-single-node
  • /test e2e-azure-operator
  • /test e2e-azure-ovn
  • /test e2e-gcp-operator

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-operator
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-azure-ovn
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-gcp-ovn-serial
  • pull-ci-openshift-cluster-ingress-operator-master-images
  • pull-ci-openshift-cluster-ingress-operator-master-unit
  • pull-ci-openshift-cluster-ingress-operator-master-verify
Details

In response to this:

/test e2e-azurestack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Contributor Author

r4f4 commented Dec 3, 2022

/retest-required

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 14, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 14, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2023
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Apr 14, 2023

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 15, 2023

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2023

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 7c2a844 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-operator 7c2a844 link true /test e2e-aws-operator
ci/prow/e2e-gcp-ovn-serial 7c2a844 link true /test e2e-gcp-ovn-serial
ci/prow/e2e-hypershift 7c2a844 link true /test e2e-hypershift

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 24, 2023

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Jun 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2023

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@candita candita Awaiting requested review from candita

@rfredette rfredette Awaiting requested review from rfredette

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@r4f4 @openshift-bot @openshift-merge-robot