Skip to content

OCPBUGS-368: Fix e2e tests for pod security violations#818

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
thejasn:fixes/e2e-pod-security
Aug 19, 2022
Merged

OCPBUGS-368: Fix e2e tests for pod security violations#818
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
thejasn:fixes/e2e-pod-security

Conversation

@thejasn
Copy link
Contributor

@thejasn thejasn commented Aug 18, 2022

This fixes the e2e breakage introduced with the recent adjustment of the default security policy.

Signed-off-by: Thejas N thn@redhat.com

Signed-off-by: Thejas N <thn@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@thejasn
Copy link
Contributor Author

thejasn commented Aug 18, 2022

/test e2e-aws-operator

2 similar comments
@thejasn
Copy link
Contributor Author

thejasn commented Aug 18, 2022

/test e2e-aws-operator

@Miciah
Copy link
Contributor

Miciah commented Aug 19, 2022

/test e2e-aws-operator

@thejasn
Copy link
Contributor Author

thejasn commented Aug 19, 2022

/test e2e-aws-operator

@thejasn thejasn marked this pull request as ready for review August 19, 2022 08:57
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2022
@openshift-ci openshift-ci bot requested review from candita and lmzuccarelli August 19, 2022 08:57
@thejasn
Copy link
Contributor Author

thejasn commented Aug 19, 2022

/test e2e-aws-operator

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2022

@thejasn: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Miciah
Copy link
Contributor

Miciah commented Aug 19, 2022

/retitle OCPBUGS-368: Fix e2e tests for pod security violations
/approve

@openshift-ci openshift-ci bot changed the title Fix e2e tests for pod security violations OCPBUGS-368: Fix e2e tests for pod security violations Aug 19, 2022
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 19, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 19, 2022

@thejasn: This pull request references [Jira Issue OCPBUGS-368](https://issues.redhat.com//browse/OCPBUGS-368), which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST)
Details

In response to this:

This fixes the e2e breakage introduced with the recent adjustment of the default security policy.

Signed-off-by: Thejas N thn@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2022
@brandisher
Copy link
Contributor

The changes look pretty straightforward. Pretty much drop everything that would allow advanced privileges since these containers don't need them.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2022
@openshift-merge-robot openshift-merge-robot merged commit 416d884 into openshift:master Aug 19, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 19, 2022

@thejasn: All pull requests linked via external trackers have merged:

[Jira Issue OCPBUGS-368](https://issues.redhat.com//browse/OCPBUGS-368) has been moved to the MODIFIED state.

Details

In response to this:

This fixes the e2e breakage introduced with the recent adjustment of the default security policy.

Signed-off-by: Thejas N thn@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants