Skip to content

Bug 2071139: add pod eviction permission#734

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
deads2k:permissions
Apr 8, 2022
Merged

Bug 2071139: add pod eviction permission#734
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
deads2k:permissions

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Apr 7, 2022

found in CI

2022-04-06T20:21:51.917897670Z E0406 20:21:51.917871 1 base_controller.go:272] spread-default-router-pods reconciliation failed: pods "router-default-84c89f5bf8-5rdcb" is forbidden: User "system:serviceaccount:openshift-ingress-operator:ingress-operator" cannot create resource "pods/eviction" in API group "" in the namespace "openshift-ingress"

Looks like the role had * on pods, but not the subresources

@openshift-ci openshift-ci bot requested review from gcs278 and rfredette April 7, 2022 13:30
@Miciah
Copy link
Contributor

Miciah commented Apr 7, 2022

/retitle Bug 2071139: add pod eviction permission

@openshift-ci openshift-ci bot changed the title add pod eviction permission Bug 2071139: add pod eviction permission Apr 7, 2022
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Apr 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 7, 2022

@deads2k: This pull request references Bugzilla bug 2071139, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2071139: add pod eviction permission

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 7, 2022
@Miciah
Copy link
Contributor

Miciah commented Apr 7, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2022
@deads2k deads2k added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 7, 2022
@deads2k
Copy link
Contributor Author

deads2k commented Apr 7, 2022

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Apr 7, 2022

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 7, 2022

@deads2k: This pull request references Bugzilla bug 2071139, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @quarterpin

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from quarterpin April 7, 2022 17:48
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 8, 2022

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d9ad657 into openshift:master Apr 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 8, 2022

@deads2k: All pull requests linked via external trackers have merged:

Bugzilla bug 2071139 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2071139: add pod eviction permission

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants