Minor improvements#61
Merged
openshift-merge-robot merged 3 commits intoopenshift:masterfrom Nov 9, 2018
Merged
Conversation
openshift-ci-robot
added
size/L
Only create resources if they don't exist. Simplifies some code and brings us closer to update diffing.
Switch to the Recreate deployment strategy because we don't do leader elections yet. Using Recreate will help us avoid contentious operators during rollouts.
Contributor
Author
|
Expecting CI to fail once since I missed the RBAC change... let's see how our e2e test does catching it. |
ironcladlou
force-pushed
the
get-or-create
branch
from
91db8e1 to
2db1f28
Compare
Contributor
Author
|
@Miciah looks like e2e failed as expected; pushed the fix and log message cleanup, PTAL. |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/retest Error from e2e-aws looks like a flake: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closer to update diffing.
yet. Using Recreate will help us avoid contentious operators during rollouts.