Bug 1907315: Change AWS interal LB annotation to match documentation #543

rfredette · 2021-02-05T20:42:00Z

Annotation service.beta.kubernetes.io/aws-load-balancer-internal is
currently set as "0.0.0.0/0" in the operator-created load balancer
service when using an internal load balancer on AWS. The prefered value
for this annotation is now "true"[1][2], although both values seem to be
valid.

[1] https://kubernetes.io/docs/concepts/services-networking/service/#internal-load-balancer
[2] https://docs.aws.amazon.com/eks/latest/userguide/load-balancing.html

openshift-ci-robot · 2021-02-05T20:42:04Z

@rfredette: This pull request references Bugzilla bug 1907315, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1907315: Change AWS interal LB annotation to match documentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rfredette · 2021-02-08T18:21:56Z

/bugzilla refresh

openshift-ci-robot · 2021-02-08T18:22:03Z

@rfredette: This pull request references Bugzilla bug 1907315, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sgreene570 · 2021-02-18T16:39:18Z

pkg/operator/controller/ingress/load_balancer_service.go

 	// https://kubernetes.io/docs/concepts/services-networking/service/#internal-load-balancer
 	InternalLBAnnotations = map[configv1.PlatformType]map[string]string{
 		configv1.AWSPlatformType: {
-			awsInternalLBAnnotation: "0.0.0.0/0",


Would it be worth dropping a comment here explaining that we used to set the annotation to 0.0.0.0/0 in prior OCP versions?

Good idea. I've updated the PR with an explanation comment.

Annotation `service.beta.kubernetes.io/aws-load-balancer-internal` is currently set as `"0.0.0.0/0"` in the operator-created load balancer service when using an internal load balancer on AWS. The prefered value for this annotation is now `"true"`[1][2], although both values seem to be valid. [1] https://kubernetes.io/docs/concepts/services-networking/service/#internal-load-balancer [2] https://docs.aws.amazon.com/eks/latest/userguide/load-balancing.html

Miciah · 2021-03-22T06:01:33Z

Thanks!
/lgtm

openshift-ci-robot · 2021-03-22T06:01:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, rfredette

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Miciah,rfredette]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-03-22T07:43:42Z

/retest