Skip to content

Read default values from install config #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 20, 2018
Merged

Read default values from install config #53

openshift-merge-robot merged 1 commit into from
Oct 20, 2018

Conversation

@ironcladlou
Copy link
Contributor

@ironcladlou ironcladlou commented Oct 18, 2018

The kco config is gone forever; get default values from the install config
instead.

@ironcladlou
Read default values from install config
d076df7 
The kco config is gone forever; get default values from the install config
instead.
@ironcladlou
Copy link
Contributor Author

ironcladlou commented Oct 18, 2018

Still need to test.

/hold

pravisankar
pravisankar approved these changes Oct 18, 2018
View reviewed changes
Copy link

@pravisankar pravisankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ironcladlou
Copy link
Contributor Author

ironcladlou commented Oct 18, 2018

I don't have a clean integration test run yet because ELBs aren't being created for the LB service in us-west-1 for some reason, but I'm pretty confident everything's working otherwise.

/hold cancel

ramr
ramr approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@ramr ramr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ... there's probably an unused file in pkg/util - can be deleted later.

@imcsk8
Copy link
Contributor

imcsk8 commented Oct 18, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 18, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imcsk8, ironcladlou, pravisankar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2018
@ironcladlou
Copy link
Contributor Author

ironcladlou commented Oct 19, 2018

/retest

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 19, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@ironcladlou
Copy link
Contributor Author

ironcladlou commented Oct 19, 2018

e2e fix is here: openshift/installer#496

@ironcladlou
Copy link
Contributor Author

ironcladlou commented Oct 19, 2018

/retest

1 similar comment
@ironcladlou
Copy link
Contributor Author

ironcladlou commented Oct 19, 2018

/retest

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 19, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 19, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 63f58ab into openshift:master Oct 20, 2018
@ramr ramr mentioned this pull request Oct 21, 2018
Merged
@Miciah Miciah mentioned this pull request Nov 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ramr ramr ramr approved these changes

@pravisankar pravisankar pravisankar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@imcsk8 imcsk8

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ironcladlou @imcsk8 @openshift-ci-robot @openshift-merge-robot @ramr @pravisankar