Skip to content

Bug 1908758: AWS: Set health check interval to 10s for NLBs #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sgreene570 wants to merge 1 commit into from
Closed

Bug 1908758: AWS: Set health check interval to 10s for NLBs #517

sgreene570 wants to merge 1 commit into from

Conversation

@sgreene570
Copy link
Contributor

@sgreene570 sgreene570 commented Dec 17, 2020 •
edited
Loading

Set the health check interval to 10s for NLBs to resolve the following error made visible in our operator e2e tests after the 1.20 rebase.

Error syncing load balancer: failed to ensure load balancer: error creating load balancer target group: \"ValidationError: Health check interval '5' not supported for target groups with the TCP protocol. Must be one of the following values '[10, 30]'"

@sgreene570
AWS: Set health check interval to 10s for NLBs
287739e 
This commit resolves BZ#1908758. See
https://docs.aws.amazon.com/elasticloadbalancing/latest/network/target-group-health-checks.html
for more information about NLB configurations for Load Balancer services.
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 17, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 17, 2020

@sgreene570: This pull request references Bugzilla bug 1908758, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1908758: AWS: Set health check interval to 10s for NLBs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 17, 2020

@sgreene570: This pull request references Bugzilla bug 1908758, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1908758: AWS: Set health check interval to 10s for NLBs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2020
@Miciah Miciah mentioned this pull request Dec 17, 2020
Merged
@sgreene570
Copy link
Contributor Author

sgreene570 commented Dec 17, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2020
@sgreene570
Copy link
Contributor Author

sgreene570 commented Dec 17, 2020 •
edited
Loading

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-ingress-operator/517/pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-operator/1339594785740034048
e2e-aws-operator pass the TestNetworkLoadBalancer test 🥳 (but failed the must-gather step).

@sgreene570
Copy link
Contributor Author

sgreene570 commented Dec 17, 2020

Let's make sure the test pass wasn't a fluke
/test e2e-aws-operator

@sgreene570
Copy link
Contributor Author

sgreene570 commented Dec 17, 2020

e2e-aws-operator is green.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 17, 2020

@sgreene570: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws 287739e link /test e2e-aws
ci/prow/e2e-upgrade 287739e link /test e2e-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sgreene570
Copy link
Contributor Author

sgreene570 commented Dec 17, 2020

/close
We will be taking miciahs PR instead of this one.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 17, 2020

@sgreene570: Closed this PR.

Details

In response to this:

/close
We will be taking miciahs PR instead of this one.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 17, 2020

@sgreene570: This pull request references Bugzilla bug 1908758. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

Bug 1908758: AWS: Set health check interval to 10s for NLBs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah Miciah mentioned this pull request Dec 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@candita candita Awaiting requested review from candita

@frobware frobware Awaiting requested review from frobware

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sgreene570 @openshift-ci-robot @openshift-merge-robot