hack: verify-generated-crd.sh should fail on diffs #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

openshift-merge-robot merged 1 commit into openshift:master from sgreene570:fix-verify-crd

Dec 3, 2020

Contributor

sgreene570 commented Nov 30, 2020

Add an exit code to the hack/verify-generated-crd.sh
script so discovered diffs return an exit code of 1,
rather than 0 (which fakes out the verify CI job).


          hack: verify-generated-crd.sh should fail on diffs

630b497

Add an exit code to the `hack/verify-generated-crd.sh`
script so discovered diffs return an exit code of 1,
rather than 0 (which fakes out the verify CI job).

openshift-ci-robot requested review from Miciah and knobunc

November 30, 2020 16:40

openshift-ci-robot added the approved label

Contributor Author

sgreene570 commented Nov 30, 2020

/hold for #498
Since this PR will fail on the current master branch, intentionally.

openshift-ci-robot added the do-not-merge/hold label

Contributor

Miciah commented Nov 30, 2020

/lgtm

openshift-ci-robot assigned Miciah

openshift-ci-robot added the lgtm label

Contributor

openshift-ci-robot commented Nov 30, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Miciah,sgreene570]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor Author

sgreene570 commented Dec 2, 2020

/hold cancel

openshift-ci-robot removed the do-not-merge/hold label

Contributor Author

sgreene570 commented Dec 2, 2020

/retest

Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments

Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-merge-robot merged commit e03f5c5 into openshift:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels