Bug 1870373: Ingress Operator reports available when DNS fails to provision by candita · Pull Request #495 · openshift/cluster-ingress-operator

candita · 2020-11-23T22:03:35Z

BZ-1870373: Ingress Operator reports available when DNS fails to provision

Check DNSReady and LoadBalancerReady when determining Availability in computeIngressAvailableCondition
Call computeIngressAvailableCondition after computing other conditions in syncIngressControllerStatus
Change unit tests for computeIngressAvailableCondition
Refactor the checks for conditions into checkConditions, to share between computeIngressAvailable and computeIngressDegraded

candita · 2020-11-23T22:05:26Z

/do-not-merge

openshift-ci-robot · 2020-11-23T22:28:34Z

@candita: This pull request references Bugzilla bug 1870373, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1870373: [WIP] Ingress Operator reports available when DNS fails to prov…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-11-23T22:33:05Z

@candita: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Bug BZ-1870373: [WIP] Ingress Operator reports available when DNS fails to prov…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

candita · 2020-11-23T22:37:10Z

/retest

pkg/operator/controller/ingress/status.go

pkg/operator/controller/ingress/status_test.go

sgreene570 · 2020-11-24T15:03:40Z

/retitle [WIP] Bug 1870373: Ingress Operator reports available when DNS fails to provision

openshift-ci-robot · 2020-11-24T15:04:01Z

@candita: This pull request references Bugzilla bug 1870373, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

[WIP] Bug 1870373: Ingress Operator reports available when DNS fails to provision

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

candita · 2020-11-24T18:07:21Z

/retitle [WIP] Bug 1870373: Ingress Operator reports available when DNS fails to provision

openshift-ci-robot · 2020-12-01T21:34:40Z

@candita: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

/test e2e-aws
/test e2e-aws-operator
/test e2e-azure
/test e2e-upgrade
/test images
/test unit
/test verify

Use /test all to run the following jobs:

pull-ci-openshift-cluster-ingress-operator-master-e2e-aws
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-operator
pull-ci-openshift-cluster-ingress-operator-master-e2e-upgrade
pull-ci-openshift-cluster-ingress-operator-master-images
pull-ci-openshift-cluster-ingress-operator-master-unit
pull-ci-openshift-cluster-ingress-operator-master-verify

Details

In response to this:

/retest e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

candita · 2020-12-01T21:35:03Z

/test e2e-aws

sgreene570 · 2020-12-02T01:08:22Z

/retest

pkg/operator/controller/ingress/status.go

pkg/operator/controller/ingress/status_test.go

openshift-ci-robot · 2020-12-02T18:01:22Z

@candita: This pull request references Bugzilla bug 1870373, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1870373: Ingress Operator reports available when DNS fails to provision

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2020-12-02T20:28:48Z

The fix looks correct, and you've added some really nice clean-ups and test coverage improvements as well. Thanks!
/lgtm

candita · 2020-12-02T21:14:52Z

/test e2e-aws-operator

candita · 2020-12-02T22:39:17Z

/test e2e-upgrade

candita · 2020-12-02T22:51:15Z

/test e2e-aws-operator

candita · 2020-12-03T02:55:05Z

/retest

openshift-bot · 2020-12-03T16:51:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

candita · 2020-12-03T18:47:27Z

/hold
Allow #493 to get in ASAP to meet deadline.

…vision

sgreene570 · 2020-12-03T22:15:46Z

/hold cancel

sgreene570 · 2020-12-03T22:19:42Z

Rebase looks good.
/lgtm
/honk

openshift-ci-robot · 2020-12-03T22:19:42Z

@sgreene570:

Details

In response to this:

Rebase looks good.
/lgtm
/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-12-03T22:20:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: candita, Miciah, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Miciah,candita,sgreene570]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-12-04T00:20:48Z

@candita: All pull requests linked via external trackers have merged:

openshift/cluster-ingress-operator#495

Bugzilla bug 1870373 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1870373: Ingress Operator reports available when DNS fails to provision

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from frobware and ironcladlou November 23, 2020 22:03

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2020

candita changed the title ~~BZ-1870373: [WIP] Ingress Operator reports available when DNS fails to prov…~~ Bug 1870373: [WIP] Ingress Operator reports available when DNS fails to prov… Nov 23, 2020

openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 23, 2020

candita force-pushed the BZ-1870373 branch from 9337f9b to 4c38597 Compare November 23, 2020 22:31

candita changed the title ~~Bug 1870373: [WIP] Ingress Operator reports available when DNS fails to prov…~~ Bug BZ-1870373: [WIP] Ingress Operator reports available when DNS fails to prov… Nov 23, 2020

openshift-ci-robot removed bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 23, 2020

candita force-pushed the BZ-1870373 branch from 4c38597 to 5b0761c Compare November 23, 2020 22:41

Miciah reviewed Nov 23, 2020

View reviewed changes

candita force-pushed the BZ-1870373 branch 3 times, most recently from 1bad1d5 to 8ad1609 Compare November 24, 2020 01:11

openshift-ci-robot changed the title ~~Bug BZ-1870373: [WIP] Ingress Operator reports available when DNS fails to prov…~~ [WIP] Bug 1870373: Ingress Operator reports available when DNS fails to provision Nov 24, 2020

candita changed the title ~~[WIP] Bug 1870373: Ingress Operator reports available when DNS fails to provision~~ Bug 1870373: [WIP] Ingress Operator reports available when DNS fails to provision Nov 24, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2020

openshift-ci-robot changed the title ~~Bug 1870373: [WIP] Ingress Operator reports available when DNS fails to provision~~ [WIP] Bug 1870373: Ingress Operator reports available when DNS fails to provision Nov 24, 2020

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2020

Miciah reviewed Dec 2, 2020

View reviewed changes

pkg/operator/controller/ingress/status.go Show resolved Hide resolved

pkg/operator/controller/ingress/status_test.go Show resolved Hide resolved

pkg/operator/controller/ingress/status_test.go Show resolved Hide resolved

candita force-pushed the BZ-1870373 branch from 4a115cb to 08e1ae5 Compare December 2, 2020 18:44

openshift-ci-robot assigned Miciah Dec 2, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2020

candita force-pushed the BZ-1870373 branch from 08e1ae5 to 5bb24b0 Compare December 3, 2020 21:16

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020

candita force-pushed the BZ-1870373 branch from 5bb24b0 to 681a7a9 Compare December 3, 2020 21:31

Bug 1870373: Ingress Operator reports available when DNS fails to pro…

496eede

…vision

candita force-pushed the BZ-1870373 branch from 681a7a9 to 496eede Compare December 3, 2020 22:03

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2020

openshift-ci-robot assigned sgreene570 Dec 3, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020

openshift-merge-robot merged commit 22bc95c into openshift:master Dec 4, 2020

Conversation

candita commented Nov 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

candita commented Nov 23, 2020

Uh oh!

openshift-ci-robot commented Nov 23, 2020

Uh oh!

openshift-ci-robot commented Nov 23, 2020

Uh oh!

candita commented Nov 23, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sgreene570 commented Nov 24, 2020

Uh oh!

openshift-ci-robot commented Nov 24, 2020

Uh oh!

candita commented Nov 24, 2020

Uh oh!

openshift-ci-robot commented Dec 1, 2020

Uh oh!

candita commented Dec 1, 2020

Uh oh!

sgreene570 commented Dec 2, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Dec 2, 2020

Uh oh!

Miciah commented Dec 2, 2020

Uh oh!

candita commented Dec 2, 2020

Uh oh!

candita commented Dec 2, 2020

Uh oh!

candita commented Dec 2, 2020

Uh oh!

candita commented Dec 3, 2020

Uh oh!

openshift-bot commented Dec 3, 2020

Uh oh!

candita commented Dec 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sgreene570 commented Dec 3, 2020

Uh oh!

sgreene570 commented Dec 3, 2020

Uh oh!

openshift-ci-robot commented Dec 3, 2020

Uh oh!

openshift-ci-robot commented Dec 3, 2020

Uh oh!

openshift-ci-robot commented Dec 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

candita commented Nov 23, 2020 •

edited

Loading

candita commented Dec 3, 2020 •

edited

Loading