Skip to content

Bump to go mod 1.15#459

Closed
sgreene570 wants to merge 1 commit intoopenshift:masterfrom
sgreene570:go-1.15
Closed

Bump to go mod 1.15#459
sgreene570 wants to merge 1 commit intoopenshift:masterfrom
sgreene570:go-1.15

Conversation

@sgreene570
Copy link
Contributor

@sgreene570 sgreene570 commented Sep 17, 2020

Bump go.mod to use go 1.15 (from go 1.13).

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2020
@sgreene570
Copy link
Contributor Author

sgreene570 commented Sep 17, 2020

requires #458
/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 17, 2020
@frobware
Copy link
Contributor

frobware commented Sep 28, 2020

Now that "requires #458" has meged

/retest

@sgreene570
go.mod: Require go 1.15 as minimum mod version
6f22dca 
Changes the go version directive in go.mod to go 1.15
to align with ART build tooling.
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 2, 2020
@sgreene570
Copy link
Contributor Author

sgreene570 commented Oct 2, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2020
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 21, 2020

@sgreene570: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-upgrade 6f22dca link /test e2e-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sgreene570
Copy link
Contributor Author

sgreene570 commented Dec 11, 2020

/close in favor of #511

@sgreene570 sgreene570 closed this Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frobware frobware Awaiting requested review from frobware

@Miciah Miciah Awaiting requested review from Miciah

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sgreene570 @openshift-ci-robot @frobware @openshift-merge-robot