Skip to content

[WIP DO NOT MERGE] Handle update events #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
imcsk8 wants to merge 3 commits into from
Closed

[WIP DO NOT MERGE] Handle update events #40

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72b1d3f
[WIP DO NOT MERGE] Handle update events
imcsk8 Sep 27, 2018
fb440d0
Change update pattern
imcsk8 Oct 3, 2018
7b7c5ee
Code cleanup
imcsk8 Oct 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pkg/stub/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,13 @@ func (h *Handler) syncIngressUpdate(ci *ingressv1alpha1.ClusterIngress) error {
err = sdk.Create(ds)
if err == nil {
logrus.Infof("created router daemonset %s/%s", ds.Namespace, ds.Name)
} else if !errors.IsAlreadyExists(err) {
} else if errors.IsAlreadyExists(err) {
err = sdk.Update(ds)
Copy link

@pravisankar pravisankar Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we know this is an update event and not resync event? (may be we want to update anyway during resync?)

Copy link
Contributor Author

@imcsk8 imcsk8 Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When @Miciah PR gets merged we will know when there's an update. I think this pattern is good for now.

if err != nil {
return fmt.Errorf("couldn't update router daemonset %s/%s", ds.Namespace, ds.Name)
}
logrus.Infof("updated router daemonset %s/%s", ds.Namespace, ds.Name)
} else {
return fmt.Errorf("failed to create daemonset %s/%s: %v", ds.Namespace, ds.Name, err)
}

Expand Down