Delete cluster DNS config from DNS provider config#365
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Mar 10, 2020
Merged
Conversation
Remove references to the cluster DNS configuration object from the configuration objects for the AWS and Azure DNS providers. Commit f4d5db3 added a reference to the cluster DNS configuration in the AWS provider configuration, and commit 32ca97d (which added the Azure provider) added a similar reference in the Azure provider configuration, but neither provider ever used the reference. * cmd/ingress-operator/start.go: Do not set the DNS field in the config argument to NewProvider. * pkg/dns/aws/dns.go (Config): * pkg/dns/azure/dns.go (Config): Delete the DNS field.
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
approved
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove references to the cluster DNS configuration object from the configuration objects for the AWS and Azure DNS providers.
#121 added a reference to the cluster DNS configuration in the AWS provider configuration, and #231 added a similar reference in the Azure provider configuration, but neither provider ever used the reference.
cmd/ingress-operator/start.go: Do not set theDNSfield in the config argument toNewProvider.pkg/dns/aws/dns.go(Config):pkg/dns/azure/dns.go(Config): Delete theDNSfield.This is just a clean-up; no functional change.