Skip to content

Bug 1788707: [release-4.2] NE-250: Support both DNSZone and PrivateDNSZone resources #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Jan 9, 2020
Merged

Bug 1788707: [release-4.2] NE-250: Support both DNSZone and PrivateDNSZone resources #344

openshift-merge-robot merged 2 commits into from
Jan 9, 2020

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jan 7, 2020

This is an automated cherry-pick of #300

/assign Miciah

@abhinavdahiya
vendor: refresh to include privatedns service
b8a73ce
@abhinavdahiya
dns/azure/client: support DNSZone type Private and PrivateDNSZone for…
b2cf1d4 
… zones

Uses the ZoneID to differentiate the type of zone, and calls the corresponding resource-type handler to PUT and DELETE the records.

* creates `recordSetClient` to manage the records for DNSZone resource type.
* creates `privateRecordSetClient` to manage the records for PrivateDNSZone resource type.
* `dnsClient` now picks one of the above based on the Zone's provider
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 7, 2020

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.2] NE-226: Support both DNSZone and PrivateDNSZone resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 7, 2020
Merged
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 7, 2020
@Miciah
Copy link
Contributor

Miciah commented Jan 7, 2020

/retitle [release-4.2] NE-250: Support both DNSZone and PrivateDNSZone resources

@openshift-ci-robot openshift-ci-robot changed the title [release-4.2] NE-226: Support both DNSZone and PrivateDNSZone resources [release-4.2] NE-250: Support both DNSZone and PrivateDNSZone resources Jan 7, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 7, 2020

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.2] NE-250: Support both DNSZone and PrivateDNSZone resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 7, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign knobunc
You can assign the PR to them by writing /assign @knobunc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ironcladlou
Copy link
Contributor

ironcladlou commented Jan 7, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 7, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 7, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 7, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@Miciah
Copy link
Contributor

Miciah commented Jan 8, 2020

/retitle Bug 1788707: [release-4.2] NE-250: Support both DNSZone and PrivateDNSZone resources

@openshift-ci-robot openshift-ci-robot changed the title [release-4.2] NE-250: Support both DNSZone and PrivateDNSZone resources Bug 1788707: [release-4.2] NE-250: Support both DNSZone and PrivateDNSZone resources Jan 8, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 8, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 8, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1788707, which is invalid:

  • expected Bugzilla bug 1788707 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1788707: [release-4.2] NE-250: Support both DNSZone and PrivateDNSZone resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtnbikenc
Copy link
Member

mtnbikenc commented Jan 8, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 8, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 8, 2020

@mtnbikenc: This pull request references Bugzilla bug 1788707, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 8, 2020
@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 9, 2020
@openshift-merge-robot openshift-merge-robot merged commit c0a5e5e into openshift:release-4.2 Jan 9, 2020
@jhixson74 jhixson74 mentioned this pull request Jan 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@ironcladlou ironcladlou

@Miciah Miciah

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@openshift-cherrypick-robot @openshift-ci-robot @Miciah @ironcladlou @openshift-bot @mtnbikenc @mrunalp @openshift-merge-robot @abhinavdahiya