-
Notifications
You must be signed in to change notification settings - Fork 218
[WIP] [release-4.20] OCPBUGS-66135: Implement HTTPKeepAliveTimeout tuning option #1312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.20
Are you sure you want to change the base?
[WIP] [release-4.20] OCPBUGS-66135: Implement HTTPKeepAliveTimeout tuning option #1312
Conversation
This commit implements `HTTPKeepAliveTimeout` tuning option of the IngressController API allowing customers to configure `timeout http-keep-alive`. In OCP versions prior to 4.16, this timeout was not respected (see haproxy/haproxy#2334). This implementation brings the ability to adjust the behavior to match pre-4.16 configurations.
Move `resolveIngressControllerAddress` and `canaryImageReference` functions from the idle connection test file to `util_test.go` because they are used in two places now. Add `checkRouteConnectivity` function to poll a route with GET requests.
|
@alebedev87: This pull request references Jira Issue OCPBUGS-66135, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retitle [WIP] [release-4.20] OCPBUGS-66135: Implement HTTPKeepAliveTimeout tuning option Until openshift/api#2607 is merged. |
|
@alebedev87: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This commit implements
HTTPKeepAliveTimeouttuning option of the IngressController API allowing customers to configuretimeout http-keep-alive.In OCP versions prior to 4.16, this timeout was not respected (see haproxy/haproxy#2334). This implementation brings the ability to adjust the behavior to match pre-4.16 configurations.