OCPBUGS-58145: reload serving cert on rotation#1285
OCPBUGS-58145: reload serving cert on rotation#1285openshift-merge-bot[bot] merged 4 commits intoopenshift:masterfrom
Conversation
|
@bentito: This pull request references Jira Issue OCPBUGS-58145, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@bentito: This pull request references Jira Issue OCPBUGS-58145, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
7 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/test e2e-aws-ovn-serial |
|
Tested with cluster bot Hence marking as verified |
|
@bentito: This pull request references Jira Issue OCPBUGS-58145, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@melvinjoseph86: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by @melvinjoseph86 |
|
@melvinjoseph86: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/cc @rfredette Brett's PR touches the same code as your PR, #1155. |
|
/assign |
|
/assign @rfredette |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
/remove-lifecycle stale |
|
also see #1334 |
rfredette
left a comment
There was a problem hiding this comment.
A few nits, but overall, this looks good to me.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfredette The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
• Compute TLS secret hash (tls.crt, tls.key, optional ca.crt) • Annotate pod template with canary-serving-cert hash • Watch canary serving cert Secret to trigger reconcile • Emit event when cert hash changes (traceability) • Update desiredCanaryDaemonSet(canaryImage, certHash) • Reconcile logic compares/propagates hash annotation • Add unit tests for hash compute and DaemonSet change detection Signed-off-by: Brett Tofel <btofel@redhat.com>
…ontext Signed-off-by: Brett Tofel <btofel@Bretts-MacBook-Pro.local>
Signed-off-by: Brett Tofel <btofel@Bretts-MacBook-Pro.local>
2f8f5ac to
ff08e12
Compare
Signed-off-by: Brett Tofel <btofel@Bretts-MacBook-Pro.local>
|
/retest |
|
/lgtm |
|
based on verification #1285 (comment) done |
|
@melvinjoseph86: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@bentito: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-aws-operator |
|
@bentito: Jira Issue Verification Checks: Jira Issue OCPBUGS-58145 Jira Issue OCPBUGS-58145 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This PR attempts to fix this bug, here's an overview of what it's doing:
• Compute TLS secret hash (tls.crt, tls.key, optional ca.crt)
• Annotate pod template with canary-serving-cert hash
• Watch canary serving cert Secret to trigger reconcile
• Emit event when cert hash changes (traceability)
• Update desiredCanaryDaemonSet(canaryImage, certHash)
• Reconcile logic compares/propagates hash annotation
• Add unit tests for hash compute and DaemonSet change detection