OCPBUGS-60492: Gateway service DNS: Add check for nil DNS Public and Private DNS zones

[sadasu]

Reconcile logic for Gateway Service Controller should check for non-nil Public and Private Zones as per the DNS API specification.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign frobware for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sadasu]

@Miciah , @alebedev87 I think this is the better fix over #1269.

The existing unit tests are expected to fail.

[patrickdillon]

@Miciah , @alebedev87 I think this is the better fix over #1269.

+1, from my understanding I think this makes the most sense (handles UPI scenarios & custom DNS), but my understanding of Gateway API and how ingress works in Custom DNS is shaky at best

The existing unit tests are expected to fail.

So they will need to be fixed up, but just waiting for approval on the approach?

[openshift-ci-robot]

@sadasu: This pull request references Jira Issue OCPBUGS-60492, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Reconcile logic for Gateway Service Controller should check for non-nil Public and Private Zones as per the DNS API specification.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sadasu]

This fix is preferred over #1269.

[openshift-ci]

@sadasu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-operator-techpreview	784cf4e	link	false	/test e2e-aws-operator-techpreview
ci/prow/e2e-azure-ovn	784cf4e	link	false	/test e2e-azure-ovn
ci/prow/e2e-gcp-operator	784cf4e	link	true	/test e2e-gcp-operator
ci/prow/e2e-aws-operator	784cf4e	link	true	/test e2e-aws-operator
ci/prow/hypershift-e2e-aks	784cf4e	link	true	/test hypershift-e2e-aks

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[sadasu]

This update to the controller is deemed unnecessary.

[openshift-ci-robot]

@sadasu: This pull request references Jira Issue OCPBUGS-60492. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Reconcile logic for Gateway Service Controller should check for non-nil Public and Private Zones as per the DNS API specification.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.