Skip to content

Comments

OCPBUGS-60302: e2e - Reduce flakiness in testGatewayAPIResourcesProtection#1265

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
alebedev87:e2e-gwapi-protection-retry
Aug 13, 2025
Merged

OCPBUGS-60302: e2e - Reduce flakiness in testGatewayAPIResourcesProtection#1265
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
alebedev87:e2e-gwapi-protection-retry

Conversation

@alebedev87
Copy link
Contributor

This PR reduces flakiness in the TestGatewayAPI/testGatewayAPIResourcesProtection e2e test by:

  • Increasing timeouts for CVO scale up/down operations and VAP assertions.
  • Retrying Gateway CRD VAP creation when network errors occur.

These changes help mitigate failures caused by temporary API server network issues and slow CVO reconciliation.

CVO is scaled up and down to allow removing and re-creating the VAP for
Gateway API CRDs. Sometimes scaling CVO up takes longer than the
previous 30 seconds timeout, so this is increased to 2 minutes.

VAP creation after scaling up CVO can also take longer than expected;
the previous 1 minute timeout was too short and caused flakiness.
Add logic to detect network errors during the creation of Gateway API
CRDs in the `testGatewayAPIResourcesProtection` test, and retry the
operation. This helps reduce flakiness caused by temporary API server
network hiccups.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 12, 2025
@openshift-ci-robot
Copy link
Contributor

@alebedev87: This pull request references Jira Issue OCPBUGS-60302, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR reduces flakiness in the TestGatewayAPI/testGatewayAPIResourcesProtection e2e test by:

  • Increasing timeouts for CVO scale up/down operations and VAP assertions.
  • Retrying Gateway CRD VAP creation when network errors occur.

These changes help mitigate failures caused by temporary API server network issues and slow CVO reconciliation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alebedev87
Copy link
Contributor Author

Test_IdleConnectionTerminationPolicyDeferred failed

    util_test.go:110: retrying client call due to: Get "http://35.222.14.66": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
    util_test.go:110: retrying client call due to: Get "http://35.222.14.66": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

This failure should be mitigated by the usage of ReplicaSet.

/test e2e-gcp-operator

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2025

@alebedev87: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 446989a link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@alebedev87
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 13, 2025
@openshift-ci-robot
Copy link
Contributor

@alebedev87: This pull request references Jira Issue OCPBUGS-60302, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from lihongan August 13, 2025 07:47
@rikatz
Copy link
Member

rikatz commented Aug 13, 2025

/assign

@rikatz
Copy link
Member

rikatz commented Aug 13, 2025

/lgtm
/approve
Thanks!

@rikatz
Copy link
Member

rikatz commented Aug 13, 2025

/hold
Hold for @candita

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Aug 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2025
@candita
Copy link
Contributor

candita commented Aug 13, 2025

/assign

@candita
Copy link
Contributor

candita commented Aug 13, 2025

We're adding up to 6 minutes on this test, which runs serially, so it's not great. If it turns into a problem we can address later.
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit afb2160 into openshift:master Aug 13, 2025
20 of 21 checks passed
@openshift-ci-robot
Copy link
Contributor

@alebedev87: Jira Issue OCPBUGS-60302: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-60302 has been moved to the MODIFIED state.

Details

In response to this:

This PR reduces flakiness in the TestGatewayAPI/testGatewayAPIResourcesProtection e2e test by:

  • Increasing timeouts for CVO scale up/down operations and VAP assertions.
  • Retrying Gateway CRD VAP creation when network errors occur.

These changes help mitigate failures caused by temporary API server network issues and slow CVO reconciliation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-ingress-operator
This PR has been included in build ose-cluster-ingress-operator-container-v4.20.0-202508140014.p0.gafb2160.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants