CORS-4174: Azure: Add Ingress LB IPs to Infra CR when in-cluster DNS is enabled #1256

sadasu · 2025-08-05T18:28:43Z

Add Ingress LB IPs to Infra CR and set DNS unmanaged when ClusterHostedDNS is enabled on Azure platform.

This functionality was previously added to GCP via #1016 and AWS via #1167.

openshift-ci-robot · 2025-08-05T18:46:09Z

@sadasu: This pull request references CORS-4174 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-08-05T18:48:08Z

@sadasu: This pull request references CORS-4174 which is a valid jira issue.

Details

In response to this:

Add Ingress LB IPs to Infra CR and set DNS unmanaged when ClusterHostedDNS is enabled on Azure platform.

This functionality was previously added to GCP via #1016 and AWS via #1167.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sadasu · 2025-08-11T23:27:58Z

/retest-required

Miciah · 2025-08-13T14:39:02Z

/assign

sadasu · 2025-08-13T17:53:50Z

/retest-required

sadasu · 2025-08-15T05:01:39Z

Based on the resolution of #1269, this PR might need to be updated.

sadasu · 2025-08-19T16:10:10Z

Based on the resolution of #1269, this PR might need to be updated.

#1269 is not absolutely necessary, so this work can be reviewed in its current state.

sadasu · 2025-08-19T17:08:11Z

/retest-required

sadasu · 2025-08-20T11:30:29Z

/retest-required

sadasu · 2025-09-24T03:25:21Z

/retest-required

sadasu · 2025-09-24T17:19:14Z

@Miciah could you PTAL? This follows the same approach taken for GCP and AWS. Please let me know if you have concerns about this.

sadasu · 2025-10-15T14:19:49Z

/retest-required

patrickdillon · 2025-11-11T01:11:07Z

/lgtm

jinyunma · 2025-11-12T05:26:19Z

pre-merge tested with this PR + cluster-ingress-operator#1256 + machine-config-operator#5401

Installations with below configs are all successful.
publish: External + userProvisionedDNS: Enabled
publish: Internal + userProvisionedDNS: Enabled
publish: Mixed + apiserver: External + ingress: Internal + userProvisionedDNS: Enabled
publish: Mixed + apiserver: Internal + ingress: External + userProvisionedDNS: Enabled

Fields "apiIntLoadBalancerIPs", "apiLoadBalancerIPs" and "ingressLoadBalancerIPs" in Infrastructure status have correct values in each scenario.

/verified by jima

openshift-ci-robot · 2025-11-12T05:26:31Z

@jinyunma: This PR has been marked as verified by jima.

Details

In response to this:

pre-merge tested with this PR + cluster-ingress-operator#1256 + machine-config-operator#5401

Installations with below configs are all successful.
publish: External + userProvisionedDNS: Enabled
publish: Internal + userProvisionedDNS: Enabled
publish: Mixed + apiserver: External + ingress: Internal + userProvisionedDNS: Enabled
publish: Mixed + apiserver: Internal + ingress: External + userProvisionedDNS: Enabled

Fields "apiIntLoadBalancerIPs", "apiLoadBalancerIPs" and "ingressLoadBalancerIPs" in Infrastructure status have correct values in each scenario.

/verified by jima

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sadasu · 2025-11-13T04:14:56Z

@Miciah , could you PTAL? Thanks!

sadasu · 2025-11-17T23:12:06Z

/retest

sadasu · 2025-11-18T03:02:30Z

/test e2e-aws-ovn-serial

openshift-ci-robot · 2025-11-21T20:34:22Z

/retest-required

Remaining retests: 0 against base HEAD 5fed704 and 0 for PR HEAD 6f8188f in total

openshift-ci-robot · 2025-11-21T21:34:12Z

/hold

Revision 6f8188f was retested 3 times: holding

sadasu · 2025-11-21T21:51:24Z

/hold cancel

openshift-ci-robot · 2025-11-21T22:34:12Z

/retest-required

Remaining retests: 0 against base HEAD b1f851e and 2 for PR HEAD 6f8188f in total

When Cluster Hosted DNS is enabled, update AzurePlatformStatus with Ingress Load Balancer IPs. Also, set DNSManagementPolicy to Unmanaged.

Add tests for the Azure Platform where the Ingress LB's IP are available but the Infra CR needs to be updated with its IP. Add tests that verify the EndpointPublishingStrategy for Azure Add tests to verify value of EndpointPublishingStrategy on Azure platform when Cluster Hosted DNS is enabled.

sadasu · 2025-11-21T23:26:04Z

/verified by jima

openshift-ci-robot · 2025-11-21T23:26:16Z

@sadasu: This PR has been marked as verified by jima.

Details

In response to this:

/verified by jima

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

alebedev87 · 2025-11-21T23:34:33Z

/lgtm

openshift-ci-robot · 2025-11-22T00:09:15Z

/retest-required

Remaining retests: 0 against base HEAD b1f851e and 2 for PR HEAD 10842ab in total

rikatz · 2025-11-22T01:53:54Z

/retest-required

rikatz · 2025-11-22T03:22:14Z

The test failing on e2e-hypershift seems to be a well known flake:
https://issues.redhat.com/browse/OCPBUGS-63717

I will wait for ovn-serial-1of2 pass, and in case it passes I am considering overriding the error

openshift-ci · 2025-11-22T04:23:01Z

@sadasu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-serial	`6f8188f`	link	true	`/test e2e-aws-ovn-serial`
ci/prow/e2e-aws-ovn-single-node	`6f8188f`	link	false	`/test e2e-aws-ovn-single-node`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

rikatz · 2025-11-22T04:23:36Z

/override ci/prow/e2e-hypershift

This test is flaky on a part that doesn't seem related with this job. The bug https://issues.redhat.com/browse/OCPBUGS-63717 shows this is also present on other jobs.

https://search.dptools.openshift.org/?search=.*EnsureGlobalPullSecret.*&maxAge=6h&context=1&type=bug%2Bissue%2Bjunit&name=.*hypershift.*&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job shows this same failure is happening on other repos and orgs.

openshift-ci · 2025-11-22T04:24:38Z

@rikatz: Overrode contexts on behalf of rikatz: ci/prow/e2e-hypershift

Details

In response to this:

/override ci/prow/e2e-hypershift

This test is flaky on a part that doesn't seem related with this job. The bug https://issues.redhat.com/browse/OCPBUGS-63717 shows this is also present on other jobs.

https://search.dptools.openshift.org/?search=.*EnsureGlobalPullSecret.*&maxAge=6h&context=1&type=bug%2Bissue%2Bjunit&name=.*hypershift.*&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job shows this same failure is happening on other repos and orgs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot requested review from Miciah and grzpiotrowski August 5, 2025 18:29

sadasu changed the title ~~Azure: Add Ingress LB IPs to Infra CR when in-cluster DNS is enabled~~ CORS-4174: Azure: Add Ingress LB IPs to Infra CR when in-cluster DNS is enabled Aug 5, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 5, 2025

openshift-ci bot assigned Miciah Aug 13, 2025

sadasu force-pushed the azure-custom-dns branch from 7c86fee to 0cc273e Compare September 23, 2025 15:47

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2025

sadasu force-pushed the azure-custom-dns branch from 0cc273e to 6f8188f Compare September 23, 2025 16:00

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2025

openshift-ci bot assigned patrickdillon Nov 11, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 12, 2025

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2025

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2025

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2025

sadasu force-pushed the azure-custom-dns branch from 6f8188f to 2c37f56 Compare November 21, 2025 22:59

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Nov 21, 2025

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2025

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2025

sadasu added 2 commits November 21, 2025 18:20

Update AzurePlatformStatus with Ingress LB IPs

b99000f

When Cluster Hosted DNS is enabled, update AzurePlatformStatus with Ingress Load Balancer IPs. Also, set DNSManagementPolicy to Unmanaged.

sadasu force-pushed the azure-custom-dns branch from 2c37f56 to 10842ab Compare November 21, 2025 23:25

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 21, 2025

openshift-ci bot assigned alebedev87 Nov 21, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2025

alebedev87 mentioned this pull request Nov 21, 2025

CORS-4229: Revert "dns/gcp: Allow configuring custom endpoints" #1302

Merged

openshift-merge-bot bot merged commit c90c02d into openshift:master Nov 22, 2025
17 checks passed

Miciah mentioned this pull request Nov 22, 2025

OCPBUGS-61858: Implement HTTPKeepAliveTimeout tuning option #1297

Merged

CORS-4174: Azure: Add Ingress LB IPs to Infra CR when in-cluster DNS is enabled #1256

CORS-4174: Azure: Add Ingress LB IPs to Infra CR when in-cluster DNS is enabled #1256

Uh oh!

Conversation

sadasu commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 5, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 5, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sadasu commented Aug 11, 2025

Uh oh!

Miciah commented Aug 13, 2025

Uh oh!

sadasu commented Aug 13, 2025

Uh oh!

sadasu commented Aug 15, 2025

Uh oh!

sadasu commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sadasu commented Aug 19, 2025

Uh oh!

sadasu commented Aug 20, 2025

Uh oh!

sadasu commented Sep 24, 2025

Uh oh!

sadasu commented Sep 24, 2025

Uh oh!

sadasu commented Oct 15, 2025

Uh oh!

patrickdillon commented Nov 11, 2025

Uh oh!

jinyunma commented Nov 12, 2025

Uh oh!

openshift-ci-robot commented Nov 12, 2025

Uh oh!

sadasu commented Nov 13, 2025

Uh oh!

sadasu commented Nov 17, 2025

Uh oh!

sadasu commented Nov 18, 2025

Uh oh!

openshift-ci-robot commented Nov 21, 2025

Uh oh!

openshift-ci-robot commented Nov 21, 2025

Uh oh!

sadasu commented Nov 21, 2025

Uh oh!

openshift-ci-robot commented Nov 21, 2025

Uh oh!

sadasu commented Nov 21, 2025

Uh oh!

openshift-ci-robot commented Nov 21, 2025

Uh oh!

alebedev87 commented Nov 21, 2025

Uh oh!

openshift-ci-robot commented Nov 22, 2025

Uh oh!

rikatz commented Nov 22, 2025

Uh oh!

rikatz commented Nov 22, 2025

Uh oh!

openshift-ci bot commented Nov 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rikatz commented Nov 22, 2025

Uh oh!

openshift-ci bot commented Nov 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

sadasu commented Aug 5, 2025 •

edited

Loading

openshift-ci-robot commented Aug 5, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Aug 5, 2025 •

edited by openshift-ci bot

Loading

sadasu commented Aug 19, 2025 •

edited

Loading

openshift-ci bot commented Nov 22, 2025 •

edited

Loading