Skip to content

OCPBUGS-59839: desiredIstio: Delete trustBundleName #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Jul 28, 2025
Merged

OCPBUGS-59839: desiredIstio: Delete trustBundleName #1243

openshift-merge-bot merged 1 commit into from
Jul 28, 2025

Conversation

@Miciah
Copy link
Contributor

@Miciah Miciah commented Jul 25, 2025 •
edited
Loading

Change desiredIstio not to set trustBundleName, which requires OSSM 3.1.

Trying to set trustBundleName caused the operator to log the following error and reconcile repeatedly:

unknown field "spec.values.global.trustBundleName"

Once we bump to OSSM 3.1, we can add this field back.

Follow-up to #1227, specifically 41d7add.

@Miciah
desiredIstio: Delete trustBundleName
c10b831 
Change desiredIstio not to set trustBundleName, which requires OSSM 3.1.

Trying to set trustBundleName caused the operator to log the following error and reconcile repeatedly:

    unknown field "spec.values.global.trustBundleName"

Once we bump to OSSM 3.1, we can add this field back.

Follow-up to commit 41d7add.

This commit fixes OCPBUGS-59839.

https://issues.redhat.com/browse/OCPBUGS-59839

* istio.go (desiredIstio): Delete trustBundleName.
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jul 25, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 25, 2025

@Miciah: This pull request references Jira Issue OCPBUGS-59839, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Change desiredIstio not to set trustBundleName, which requires OSSM 3.1.

Trying to set trustBundleName caused the operator to log the following error and reconcile repeatedly:

unknown field "spec.values.global.trustBundleName"

Once we bump to OSSM 3.1, we can add this field back.

Follow-up to 41d7add.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 25, 2025
@openshift-ci openshift-ci bot requested review from Thealisyed and rfredette July 25, 2025 19:55
@Miciah Miciah mentioned this pull request Jul 25, 2025
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2025 •
edited
Loading

@Miciah: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-techpreview c10b831 link false /test e2e-aws-ovn-techpreview
ci/prow/e2e-azure-ovn c10b831 link false /test e2e-azure-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@alebedev87
Copy link
Contributor

alebedev87 commented Jul 26, 2025

/assign

alebedev87
alebedev87 approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@alebedev87 alebedev87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, trustBundleName is available in Istio 3.1 but not in Istio 3.0.

@alebedev87
Copy link
Contributor

alebedev87 commented Jul 28, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2025
@Miciah
Copy link
Contributor Author

Miciah commented Jul 28, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 28, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 28, 2025

@Miciah: This pull request references Jira Issue OCPBUGS-59839, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (iamin@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Miciah
Copy link
Contributor Author

Miciah commented Jul 28, 2025

e2e-azure-operator failed because TestManagedDNSToUnmanagedDNSIngressController failed. We have OCPBUGS-17671 to track failures of this test on Azure.

/test e2e-azure-operator

@openshift-merge-bot openshift-merge-bot bot merged commit 5bfbb60 into openshift:master Jul 28, 2025
20 of 22 checks passed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 28, 2025

@Miciah: Jira Issue OCPBUGS-59839: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-59839 has been moved to the MODIFIED state.

Details

In response to this:

Change desiredIstio not to set trustBundleName, which requires OSSM 3.1.

Trying to set trustBundleName caused the operator to log the following error and reconcile repeatedly:

unknown field "spec.values.global.trustBundleName"

Once we bump to OSSM 3.1, we can add this field back.

Follow-up to #1227, specifically 41d7add.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 29, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-ingress-operator
This PR has been included in build ose-cluster-ingress-operator-container-v4.20.0-202507282313.p0.g5bfbb60.assembly.stream.el9.
All builds following this will include this PR.

@Miciah
Copy link
Contributor Author

Miciah commented Jul 29, 2025

#1244 incorporates #1243, so #1243 does not need to be backported.

@Miciah Miciah mentioned this pull request Jul 31, 2025
Merged
skriss added a commit to skriss/cluster-ingress-operator that referenced this pull request Oct 2, 2025
@skriss
set trustBundleName in Istio global values
85b6fc9 
Sets trustBundleName in order to customize the
name of the configmap containing the CA cert so
it doesn't clash with a standalone OSSM instance.

Follow-up to openshift#1243.

Signed-off-by: Steve Kriss <skriss@redhat.com>
@skriss skriss mentioned this pull request Oct 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alebedev87 alebedev87 alebedev87 approved these changes

@rfredette rfredette Awaiting requested review from rfredette

@Thealisyed Thealisyed Awaiting requested review from Thealisyed

Assignees

@alebedev87 alebedev87

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Miciah @openshift-ci-robot @alebedev87 @openshift-bot