OCPBUGS-55673: Remove IngressControllerLBSubnetsAWS featuregate #1242

grzpiotrowski · 2025-07-10T11:42:45Z

The IngressControllerLBSubnetsAWS feature gate was at first introduced as TPNU in OpenShift 4.17 and was promoted to Default in the same release. The feature gate has been enabled by default for 3 releases, so it is scheduled to be removed imminently.

The feature itself (ability to choose AWS subnets for LoadBalancer Service) remains, only the feature gate check is removed.

Follow-up to the commit which introduced the feature gate: 26dfe2c

Feature was added as TPNU in: openshift/api#1841
Feature was promoted to Default (GA) in: openshift/api#1966

pkg/operator/controller/ingress/controller.go: Remove IngressControllerLBSubnetsAWSEnabled from Config.
pkg/operator/controller/ingress/load_balancer_service.go:
- (desiredLoadBalancerService): Remove subnetsAWSEnabled featuregate checks and the redundant function parameter.
- (loadBalancerServiceIsUpgradeable): Remove featuregate check from the LB Service upgradeability calculation.
- (loadBalancerServiceIsProgressing): Remove featuregate check from LB Service progressing calculation.
pkg/operator/controller/ingress/load_balancer_service_test.go: Update desiredLoadBalancerService function calls after removing the subnetsAWSEnabled parameter.
pkg/operator/controller/ingress/status.go:
- (syncIngressControllerStatus): Remove LBSubnetsAWS featuregate check from the IC status computation.
- (computeIngressUpgradeableCondition): Remove subnetsAWSEnabled featuregate check.
- (computeLoadBalancerProgressingStatus): Remove subnetsAWSEnabled from the LB progressing status computation.
pkg/operator/controller/ingress/status_test.go
- (Test_computeLoadBalancerProgressingStatus): Remove test case with the LBSubnetsAWS featuregate disabled. Remove awsSubnetsEnabled boolean since it is not needed anymore.
- (Test_computeIngressUpgradeableCondition): Update function calls after the featuregate check paramter was removed.
- (Test_computeIngressEvaluationConditionsDetectedCondition): Update function calls after the featuregate check parameter was removed.
pkg/operator/operator.go:
- (New): Remove ingressControllerLBSubnetsAWSEnabled featuregate check.
test/e2e/lb_subnets_test.go:
- (TestAWSLBSubnets): Remove featuregate check.
- (TestUnmanagedAWSLBSubnets): Remove featuregate check.

openshift-ci-robot · 2025-07-10T11:42:58Z

@grzpiotrowski: This pull request references Jira Issue OCPBUGS-55673, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.0) matches configured target version for branch (4.20.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The IngressControllerLBSubnetsAWS feature gate was at first introduced as TPNU in OpenShift 4.17 and was promoted to Default in the same release. The feature gate has been enabled by default for 3 releases, so it is scheduled to be removed imminently.

The feature itself (ability to choose AWS subnets for LoadBalancer Service) remains, only the feature gate check is removed.

Follow-up to the commit which introduced the feature gate: 26dfe2c

Feature was added as TPNU in: openshift/api#1841
Feature was promoted to Default (GA) in: openshift/api#1966

pkg/operator/controller/ingress/controller.go: Remove IngressControllerLBSubnetsAWSEnabled from Config.

pkg/operator/controller/ingress/load_balancer_service.go: (desiredLoadBalancerService): Remove subnetsAWSEnabled featuregate checks and the redundant function parameter.
(loadBalancerServiceIsUpgradeable): Remove featuregate check from the LB Service upgradeability calculation.
(loadBalancerServiceIsProgressing): Remove featuregate check from LB Service progressing calculation.

pkg/operator/controller/ingress/load_balancer_service_test.go: Update desiredLoadBalancerService function calls after removing the subnetsAWSEnabled parameter.desiredLoadBalancerService

pkg/operator/controller/ingress/status.go: (syncIngressControllerStatus): Remove LBSubnetsAWS featuregate check from the IC status computation.
(computeIngressUpgradeableCondition): Remove subnetsAWSEnabled featuregate check (computeLoadBalancerProgressingStatus): Remove subnetsAWSEnabled from the LB upgradeable condition computation. (computeLoadBalancerProgressingStatus): Remove subnetsAWSEnabled from the LB progressing status computation.

pkg/operator/controller/ingress/status_test.go (Test_computeLoadBalancerProgressingStatus): Remove test case with the LBSubnetsAWS featuregate disabled.
(Test_computeIngressUpgradeableCondition): Update function calls after the featuregate check paramter was removed.
(Test_computeIngressEvaluationConditionsDetectedCondition): Update function calls after the featuregate check parameter was removed.

pkg/operator/operator.go: (New): Remove ingressControllerLBSubnetsAWSEnabled featuregate check.

test/e2e/lb_subnets_test.go: (TestAWSLBSubnets): Remove featuregate check.
(TestUnmanagedAWSLBSubnets): Remove featuregate check.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

grzpiotrowski · 2025-07-10T18:45:37Z

/retest

I couldn't see anything related to the changes.

alebedev87 · 2025-07-16T14:56:39Z

/assign @rfredette

grzpiotrowski · 2025-07-24T11:40:53Z

/retest

grzpiotrowski · 2025-07-28T15:47:22Z

/retest

grzpiotrowski · 2025-07-29T10:42:25Z

/test e2e-aws-ovn-single-node

{  static pod lifecycle failure - static pod: "kube-apiserver" in namespace: "openshift-kube-apiserver" for revision: 4 on node: "[...]" didn't show up, waited: 3m15s}

candita · 2025-08-20T15:27:59Z

/unassign @rfredette
/assign @rikatz

candita · 2025-08-20T15:31:50Z

/assign

pkg/operator/controller/ingress/status_test.go

Miciah · 2025-08-20T15:54:03Z

The commit message is missing a line break here:

(computeIngressUpgradeableCondition): Remove subnetsAWSEnabled
featuregate check (computeLoadBalancerProgressingStatus): Remove
subnetsAWSEnabled from the LB upgradeable condition computation.

Edit: Actually, you have computeLoadBalancerProgressingStatus twice. You can delete the first one (the one I quoted above); the first one wrongly mentions the "upgradeable" status condition whereas the second one correctly mentions the "progressing" status condition.

Miciah · 2025-08-20T15:55:50Z

Also, the commit message has an extra "desiredLoadBalancerService" here:

* pkg/operator/controller/ingress/load_balancer_service_test.go:
Update desiredLoadBalancerService function calls after removing the
subnetsAWSEnabled parameter.desiredLoadBalancerService

The IngressControllerLBSubnetsAWS feature gate was at first introduced as TPNU in OpenShift 4.17 and was promoted to Default in the same release. The feature gate has been enabled by default for 3 releases, so it is scheduled to be removed imminently. The feature itself (ability to choose AWS subnets for LoadBalancer Service) remains, only the feature gate check is removed. This commit addresses OCPBUGS-55673: https://issues.redhat.com/browse/OCPBUGS-55673 Follow-up to the commit which introduced the feature gate: openshift@26dfe2c * pkg/operator/controller/ingress/controller.go: Remove IngressControllerLBSubnetsAWSEnabled from Config. * pkg/operator/controller/ingress/load_balancer_service.go: (desiredLoadBalancerService): Remove subnetsAWSEnabled featuregate checks and the redundant function parameter. (loadBalancerServiceIsUpgradeable): Remove featuregate check from the LB Service upgradeability calculation. (loadBalancerServiceIsProgressing): Remove featuregate check from LB Service progressing calculation. * pkg/operator/controller/ingress/load_balancer_service_test.go: Update desiredLoadBalancerService function calls after removing the subnetsAWSEnabled parameter. * pkg/operator/controller/ingress/status.go: (syncIngressControllerStatus): Remove LBSubnetsAWS featuregate check from the IC status computation. (computeIngressUpgradeableCondition): Remove subnetsAWSEnabled featuregate check. (computeLoadBalancerProgressingStatus): Remove subnetsAWSEnabled from the LB progressing status computation. * pkg/operator/controller/ingress/status_test.go (Test_computeLoadBalancerProgressingStatus): Remove test case with the LBSubnetsAWS featuregate disabled. Remove awsSubnetsEnabled boolean since it is not needed anymore. (Test_computeIngressUpgradeableCondition): Update function calls after the featuregate check paramter was removed. (Test_computeIngressEvaluationConditionsDetectedCondition): Update function calls after the featuregate check parameter was removed. * pkg/operator/operator.go: (New): Remove ingressControllerLBSubnetsAWSEnabled featuregate check. * test/e2e/lb_subnets_test.go: (TestAWSLBSubnets): Remove featuregate check. (TestUnmanagedAWSLBSubnets): Remove featuregate check.

openshift-ci-robot · 2025-08-20T16:21:47Z

@grzpiotrowski: This pull request references Jira Issue OCPBUGS-55673, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.0) matches configured target version for branch (4.20.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

The IngressControllerLBSubnetsAWS feature gate was at first introduced as TPNU in OpenShift 4.17 and was promoted to Default in the same release. The feature gate has been enabled by default for 3 releases, so it is scheduled to be removed imminently.

The feature itself (ability to choose AWS subnets for LoadBalancer Service) remains, only the feature gate check is removed.

Follow-up to the commit which introduced the feature gate: 26dfe2c

Feature was added as TPNU in: openshift/api#1841
Feature was promoted to Default (GA) in: openshift/api#1966

pkg/operator/controller/ingress/controller.go: Remove IngressControllerLBSubnetsAWSEnabled from Config.

pkg/operator/controller/ingress/load_balancer_service.go:

(desiredLoadBalancerService): Remove subnetsAWSEnabled featuregate checks and the redundant function parameter.

(loadBalancerServiceIsUpgradeable): Remove featuregate check from the LB Service upgradeability calculation.

(loadBalancerServiceIsProgressing): Remove featuregate check from LB Service progressing calculation.

pkg/operator/controller/ingress/load_balancer_service_test.go: Update desiredLoadBalancerService function calls after removing the subnetsAWSEnabled parameter.

pkg/operator/controller/ingress/status.go:

(syncIngressControllerStatus): Remove LBSubnetsAWS featuregate check from the IC status computation.

(computeIngressUpgradeableCondition): Remove subnetsAWSEnabled featuregate check.

(computeLoadBalancerProgressingStatus): Remove subnetsAWSEnabled from the LB progressing status computation.

pkg/operator/controller/ingress/status_test.go

(Test_computeLoadBalancerProgressingStatus): Remove test case with the LBSubnetsAWS featuregate disabled. Remove awsSubnetsEnabled boolean since it is not needed anymore.

(Test_computeIngressUpgradeableCondition): Update function calls after the featuregate check paramter was removed.

(Test_computeIngressEvaluationConditionsDetectedCondition): Update function calls after the featuregate check parameter was removed.

pkg/operator/operator.go:

(New): Remove ingressControllerLBSubnetsAWSEnabled featuregate check.

test/e2e/lb_subnets_test.go:

(TestAWSLBSubnets): Remove featuregate check.

(TestUnmanagedAWSLBSubnets): Remove featuregate check.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

grzpiotrowski · 2025-08-20T21:15:51Z

/retest

grzpiotrowski · 2025-08-21T00:17:09Z

e2e-gcp-operator test failed in the same way that we see in other PRs. Not related to the changes.

rikatz · 2025-08-21T19:55:37Z

overall lgtm, not sure if this needs to be removed also from some API, but I have checked some other project code and couldn't find any reference to this feature flag

/cc @candita

for final review

candita · 2025-08-21T22:36:02Z

@rikatz this is removed from openshift/api in openshift/api#2400, but this PR needs to merge first.

@grzpiotrowski Nice job on the commit message!

/override e2e-gcp-operator
/lgtm
/approve

openshift-ci-robot · 2025-08-22T10:36:59Z

/retest-required

Remaining retests: 0 against base HEAD b609eb2 and 1 for PR HEAD cc00436 in total

openshift-ci-robot · 2025-08-22T15:02:25Z

/retest-required

Remaining retests: 0 against base HEAD b609eb2 and 2 for PR HEAD cc00436 in total

openshift-ci-robot · 2025-08-22T17:46:05Z

/retest-required

Remaining retests: 0 against base HEAD b609eb2 and 2 for PR HEAD cc00436 in total

openshift-ci-robot · 2025-08-24T13:23:28Z

/retest-required

Remaining retests: 0 against base HEAD b609eb2 and 2 for PR HEAD cc00436 in total

candita · 2025-08-25T15:33:49Z

/override ci/prow/e2e-gcp-operator

openshift-ci · 2025-08-25T15:34:27Z

@candita: Overrode contexts on behalf of candita: ci/prow/e2e-gcp-operator

Details

In response to this:

/override ci/prow/e2e-gcp-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

grzpiotrowski · 2025-08-27T13:39:56Z

/retest-required

openshift-bot · 2025-09-02T09:11:45Z

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

openshift-ci-robot · 2025-09-02T09:12:16Z

@openshift-bot: This pull request references Jira Issue OCPBUGS-55673, which is invalid:

expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.20.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

grzpiotrowski · 2025-09-03T14:51:02Z

/jira refresh

openshift-ci-robot · 2025-09-03T14:51:10Z

@grzpiotrowski: This pull request references Jira Issue OCPBUGS-55673, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Miciah · 2025-09-15T18:07:16Z

/refresh

lihongan · 2025-09-18T03:58:31Z

/label qa-approved
/verified by @lihongan

launch cluster-bot with this PR and the function is still working well (on both CLB and NLB)

  endpointPublishingStrategy:
    loadBalancer:
      dnsManagementPolicy: Managed
      providerParameters:
        aws:
          classicLoadBalancer:
            connectionIdleTimeout: 0s
            subnets:
              names:
              - ci-ln-ybyxdqt-76ef8-2xfkf-subnet-public-us-west-1b
              - ci-ln-ybyxdqt-76ef8-2xfkf-subnet-public-us-west-1c
          type: Classic
        type: AWS

  endpointPublishingStrategy:
    loadBalancer:
      dnsManagementPolicy: Managed
      providerParameters:
        aws:
          networkLoadBalancer:
            subnets:
              names:
              - ci-ln-ybyxdqt-76ef8-2xfkf-subnet-public-us-west-1b
              - ci-ln-ybyxdqt-76ef8-2xfkf-subnet-public-us-west-1c
          type: NLB
        type: AWS
      scope: External
    type: LoadBalancerService

openshift-ci · 2025-09-18T03:58:34Z

@lihongan: The label(s) /label qa-approved cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, run-integration-tests, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, ok-to-test, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label qa-approved
/verified by @lihongan

launch cluster-bot with this PR and the function is still working well (on both CLB and NLB)

 endpointPublishingStrategy:
   loadBalancer:
     dnsManagementPolicy: Managed
     providerParameters:
       aws:
         classicLoadBalancer:
           connectionIdleTimeout: 0s
           subnets:
             names:
             - ci-ln-ybyxdqt-76ef8-2xfkf-subnet-public-us-west-1b
             - ci-ln-ybyxdqt-76ef8-2xfkf-subnet-public-us-west-1c
         type: Classic
       type: AWS

 endpointPublishingStrategy:
   loadBalancer:
     dnsManagementPolicy: Managed
     providerParameters:
       aws:
         networkLoadBalancer:
           subnets:
             names:
             - ci-ln-ybyxdqt-76ef8-2xfkf-subnet-public-us-west-1b
             - ci-ln-ybyxdqt-76ef8-2xfkf-subnet-public-us-west-1c
         type: NLB
       type: AWS
     scope: External
   type: LoadBalancerService

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2025-09-18T03:58:43Z

@lihongan: This PR has been marked as verified by @lihongan.

Details

In response to this:

/label qa-approved
/verified by @lihongan

launch cluster-bot with this PR and the function is still working well (on both CLB and NLB)

 endpointPublishingStrategy:
   loadBalancer:
     dnsManagementPolicy: Managed
     providerParameters:
       aws:
         classicLoadBalancer:
           connectionIdleTimeout: 0s
           subnets:
             names:
             - ci-ln-ybyxdqt-76ef8-2xfkf-subnet-public-us-west-1b
             - ci-ln-ybyxdqt-76ef8-2xfkf-subnet-public-us-west-1c
         type: Classic
       type: AWS

 endpointPublishingStrategy:
   loadBalancer:
     dnsManagementPolicy: Managed
     providerParameters:
       aws:
         networkLoadBalancer:
           subnets:
             names:
             - ci-ln-ybyxdqt-76ef8-2xfkf-subnet-public-us-west-1b
             - ci-ln-ybyxdqt-76ef8-2xfkf-subnet-public-us-west-1c
         type: NLB
       type: AWS
     scope: External
   type: LoadBalancerService

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

lihongan · 2025-09-18T03:59:27Z

/label qe-approved

openshift-ci-robot · 2025-09-18T03:59:33Z

@grzpiotrowski: This pull request references Jira Issue OCPBUGS-55673, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

The IngressControllerLBSubnetsAWS feature gate was at first introduced as TPNU in OpenShift 4.17 and was promoted to Default in the same release. The feature gate has been enabled by default for 3 releases, so it is scheduled to be removed imminently.

The feature itself (ability to choose AWS subnets for LoadBalancer Service) remains, only the feature gate check is removed.

Follow-up to the commit which introduced the feature gate: 26dfe2c

Feature was added as TPNU in: openshift/api#1841
Feature was promoted to Default (GA) in: openshift/api#1966

pkg/operator/controller/ingress/controller.go: Remove IngressControllerLBSubnetsAWSEnabled from Config.

pkg/operator/controller/ingress/load_balancer_service.go:

(desiredLoadBalancerService): Remove subnetsAWSEnabled featuregate checks and the redundant function parameter.

(loadBalancerServiceIsUpgradeable): Remove featuregate check from the LB Service upgradeability calculation.

(loadBalancerServiceIsProgressing): Remove featuregate check from LB Service progressing calculation.

pkg/operator/controller/ingress/load_balancer_service_test.go: Update desiredLoadBalancerService function calls after removing the subnetsAWSEnabled parameter.

pkg/operator/controller/ingress/status.go:

(syncIngressControllerStatus): Remove LBSubnetsAWS featuregate check from the IC status computation.

(computeIngressUpgradeableCondition): Remove subnetsAWSEnabled featuregate check.

(computeLoadBalancerProgressingStatus): Remove subnetsAWSEnabled from the LB progressing status computation.

pkg/operator/controller/ingress/status_test.go

(Test_computeLoadBalancerProgressingStatus): Remove test case with the LBSubnetsAWS featuregate disabled. Remove awsSubnetsEnabled boolean since it is not needed anymore.

(Test_computeIngressUpgradeableCondition): Update function calls after the featuregate check paramter was removed.

(Test_computeIngressEvaluationConditionsDetectedCondition): Update function calls after the featuregate check parameter was removed.

pkg/operator/operator.go:

(New): Remove ingressControllerLBSubnetsAWSEnabled featuregate check.

test/e2e/lb_subnets_test.go:

(TestAWSLBSubnets): Remove featuregate check.

(TestUnmanagedAWSLBSubnets): Remove featuregate check.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-09-18T06:17:15Z

/retest-required

Remaining retests: 0 against base HEAD 3233796 and 2 for PR HEAD cc00436 in total

grzpiotrowski · 2025-09-18T10:00:22Z

/retest

openshift-ci · 2025-09-18T14:00:37Z

@grzpiotrowski: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-09-18T14:04:20Z

@grzpiotrowski: Jira Issue OCPBUGS-55673: Some pull requests linked via external trackers have merged:

openshift/cluster-ingress-operator#1242

The following pull request, linked via external tracker, has not merged:

openshift/api#2400 is open

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-55673 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

The IngressControllerLBSubnetsAWS feature gate was at first introduced as TPNU in OpenShift 4.17 and was promoted to Default in the same release. The feature gate has been enabled by default for 3 releases, so it is scheduled to be removed imminently.

The feature itself (ability to choose AWS subnets for LoadBalancer Service) remains, only the feature gate check is removed.

Follow-up to the commit which introduced the feature gate: 26dfe2c

Feature was added as TPNU in: openshift/api#1841
Feature was promoted to Default (GA) in: openshift/api#1966

pkg/operator/controller/ingress/controller.go: Remove IngressControllerLBSubnetsAWSEnabled from Config.

pkg/operator/controller/ingress/load_balancer_service.go:

(desiredLoadBalancerService): Remove subnetsAWSEnabled featuregate checks and the redundant function parameter.

(loadBalancerServiceIsUpgradeable): Remove featuregate check from the LB Service upgradeability calculation.

(loadBalancerServiceIsProgressing): Remove featuregate check from LB Service progressing calculation.

pkg/operator/controller/ingress/load_balancer_service_test.go: Update desiredLoadBalancerService function calls after removing the subnetsAWSEnabled parameter.

pkg/operator/controller/ingress/status.go:

(syncIngressControllerStatus): Remove LBSubnetsAWS featuregate check from the IC status computation.

(computeIngressUpgradeableCondition): Remove subnetsAWSEnabled featuregate check.

(computeLoadBalancerProgressingStatus): Remove subnetsAWSEnabled from the LB progressing status computation.

pkg/operator/controller/ingress/status_test.go

(Test_computeLoadBalancerProgressingStatus): Remove test case with the LBSubnetsAWS featuregate disabled. Remove awsSubnetsEnabled boolean since it is not needed anymore.

(Test_computeIngressUpgradeableCondition): Update function calls after the featuregate check paramter was removed.

(Test_computeIngressEvaluationConditionsDetectedCondition): Update function calls after the featuregate check parameter was removed.

pkg/operator/operator.go:

(New): Remove ingressControllerLBSubnetsAWSEnabled featuregate check.

test/e2e/lb_subnets_test.go:

(TestAWSLBSubnets): Remove featuregate check.

(TestUnmanagedAWSLBSubnets): Remove featuregate check.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2025-10-02T13:23:22Z

Fix included in accepted release 4.21.0-0.nightly-2025-10-02-002727

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 10, 2025

openshift-ci bot requested review from Thealisyed, candita and lihongan July 10, 2025 11:43

grzpiotrowski mentioned this pull request Jul 10, 2025

OCPBUGS-55673: Remove IngressControllerLBSubnetsAWS featuregate openshift/api#2400

Merged

Miciah mentioned this pull request Jul 11, 2025

NE-2022: Bump to OSSM 3.0.1 and Istio 1.24.4 #1227

Merged

openshift-ci bot assigned rfredette Jul 16, 2025

openshift-ci bot assigned rikatz and unassigned rfredette Aug 20, 2025

openshift-ci bot assigned candita Aug 20, 2025

Miciah reviewed Aug 20, 2025

View reviewed changes

pkg/operator/controller/ingress/status_test.go Show resolved Hide resolved

grzpiotrowski force-pushed the OCPBUGS-55673-remove-ic-lb-subnets-aws-featuregate branch from 18cb81d to cc00436 Compare August 20, 2025 16:17

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2025

openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 2, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 3, 2025

rikatz mentioned this pull request Sep 17, 2025

OCPBUGS-55649: Remove SetEIPForNLBIngressController feature gate #1280

Merged

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 18, 2025

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 18, 2025

openshift-merge-bot bot merged commit c968596 into openshift:master Sep 18, 2025
21 checks passed

OCPBUGS-55673: Remove IngressControllerLBSubnetsAWS featuregate #1242

OCPBUGS-55673: Remove IngressControllerLBSubnetsAWS featuregate #1242

Uh oh!

Conversation

grzpiotrowski commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 10, 2025

Uh oh!

grzpiotrowski commented Jul 10, 2025

Uh oh!

alebedev87 commented Jul 16, 2025

Uh oh!

grzpiotrowski commented Jul 24, 2025

Uh oh!

grzpiotrowski commented Jul 28, 2025

Uh oh!

grzpiotrowski commented Jul 29, 2025

Uh oh!

candita commented Aug 20, 2025

Uh oh!

candita commented Aug 20, 2025

Uh oh!

Uh oh!

Miciah commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Miciah commented Aug 20, 2025

Uh oh!

openshift-ci-robot commented Aug 20, 2025

Uh oh!

grzpiotrowski commented Aug 20, 2025

Uh oh!

grzpiotrowski commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rikatz commented Aug 21, 2025

Uh oh!

candita commented Aug 21, 2025

Uh oh!

openshift-ci-robot commented Aug 22, 2025

Uh oh!

openshift-ci-robot commented Aug 22, 2025

Uh oh!

openshift-ci-robot commented Aug 22, 2025

Uh oh!

openshift-ci-robot commented Aug 24, 2025

Uh oh!

candita commented Aug 25, 2025

Uh oh!

openshift-ci bot commented Aug 25, 2025

Uh oh!

grzpiotrowski commented Aug 27, 2025

Uh oh!

openshift-bot commented Sep 2, 2025

Uh oh!

openshift-ci-robot commented Sep 2, 2025

Uh oh!

grzpiotrowski commented Sep 3, 2025

Uh oh!

openshift-ci-robot commented Sep 3, 2025

Uh oh!

Miciah commented Sep 15, 2025

Uh oh!

lihongan commented Sep 18, 2025

Uh oh!

openshift-ci bot commented Sep 18, 2025

Uh oh!

openshift-ci-robot commented Sep 18, 2025

Uh oh!

lihongan commented Sep 18, 2025

Uh oh!

openshift-ci-robot commented Sep 18, 2025

Uh oh!

openshift-ci-robot commented Sep 18, 2025

Uh oh!

grzpiotrowski commented Sep 18, 2025

Uh oh!

openshift-ci bot commented Sep 18, 2025

Uh oh!

grzpiotrowski commented Jul 10, 2025 •

edited

Loading

Miciah commented Aug 20, 2025 •

edited

Loading

grzpiotrowski commented Aug 21, 2025 •

edited

Loading