Skip to content

Conversation

@aslakknutsen
Copy link
Contributor

@aslakknutsen aslakknutsen commented Apr 1, 2025

Avoid conflict with a user control plane by setting a custom CA Bundle CM name for the Gateway Control plane and enable istio to only inject CA Bundle CMs in namespaces where Gateways exist to avoid poluting the whole cluster.

Two new Env variables set for the Istio control plane deployment CR;
PILOT_CA_CERT_CONFIGMAP
PILOT_ENABLE_GATEWAY_API_CA_CERT_ONLY

Related to OSSM-9076

Requires OSSM 3.0.1 to work, but not to merge.

Depends on

Avoid conflict with a user control plane by setting a custom CA Bundle CM name
for the Gateway Control plane and enable istio to only inject CA Bundle CMs in
namespaces where Gateways exist to avoid poluting the whole cluster.

Two new Env variables set for the Istio control plane deployment CR;
  PILOT_CA_CERT_CONFIGMAP
  PILOT_ENABLE_GATEWAY_API_CA_CERT_ONLY

Related to OSSM-9076
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 1, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign frobware for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aslakknutsen aslakknutsen marked this pull request as ready for review April 8, 2025 17:35
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2025
@openshift-ci openshift-ci bot requested review from gcs278 and grzpiotrowski April 8, 2025 17:36
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 15, 2025

@aslakknutsen: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@candita
Copy link
Contributor

candita commented May 28, 2025

@Miciah will contact @aslakknutsen regarding this being incorporated in another PR.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2025
@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 27, 2025
@aslakknutsen
Copy link
Contributor Author

Merged via other commits. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants