Skip to content

WIP: dns: clean DNS records on clusteringress deletion#114

Closed
ironcladlou wants to merge 1 commit intoopenshift:masterfrom
ironcladlou:dns-deletion
Closed

WIP: dns: clean DNS records on clusteringress deletion#114
ironcladlou wants to merge 1 commit intoopenshift:masterfrom
ironcladlou:dns-deletion

Conversation

@ironcladlou
Copy link
Contributor

When a clusteringress is deleted, ensure that any existing DNS records created
for a load balancer service are also deleted.

When a clusteringress is deleted, ensure that any existing DNS records created
for a load balancer service are also deleted.
@ironcladlou
Copy link
Contributor Author

Have done manual testing but need to think about how to do an e2e...

@ironcladlou
Copy link
Contributor Author

Problem here is that we assume that if the ALIAS name and target match then we own the record, but I'm not entirely sure how we can establish a stronger correlation without reinventing external-dns...

@openshift-merge-robot
Copy link
Contributor

/retest

1 similar comment
@openshift-merge-robot
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link
Contributor

@ironcladlou: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 02bb647 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2019
@openshift-ci-robot
Copy link
Contributor

@ironcladlou: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ironcladlou
Copy link
Contributor Author

Depends on openshift/api#202

@ironcladlou ironcladlou changed the title dns: clean DNS records on clusteringress deletion WIP: dns: clean DNS records on clusteringress deletion Feb 7, 2019
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 7, 2019
@ironcladlou
Copy link
Contributor Author

Replaced by #121

/close

@openshift-ci-robot
Copy link
Contributor

@ironcladlou: Closed this PR.

Details

In response to this:

Replaced by #121

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants