[release-4.14] OCPBUGS-36555: Implement connect timeout tuning option

[alebedev87]

Backport of #1097.

[openshift-ci-robot]

@alebedev87: This pull request references Jira Issue OCPBUGS-36555, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Backport of #1097.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[alebedev87]

/jira refresh

[openshift-ci-robot]

@alebedev87: This pull request references Jira Issue OCPBUGS-36555, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.z) matches configured target version for branch (4.14.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-36208 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-36208 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
• bug has dependents

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[alebedev87]

/retest

[openshift-ci]

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[lihongan]

/label qe-approved
/label cherry-pick-approved
verified by pre-merge testing

$ oc get clusterversion
NAME      VERSION                                                   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.14.0-0.ci.test-2024-07-12-013316-ci-ln-9by3v3k-latest   True        False         2m2s    Cluster version is 4.14.0-0.ci.test-2024-07-12-013316-ci-ln-9by3v3k-latest

$ oc explain ingresscontroller.spec.tuningOptions.connectTimeout
GROUP:      operator.openshift.io
KIND:       IngressController
VERSION:    v1

FIELD: connectTimeout <string>

DESCRIPTION:
    ConnectTimeout defines the maximum time to wait for a connection attempt to
    a server/backend to succeed. 
     This field expects an unsigned duration string of decimal numbers, each
    with optional fraction and a unit suffix, e.g. "300ms", "1.5h" or "2h45m".
    Valid time units are "ns", "us" (or "µs" U+00B5 or "μs" U+03BC), "ms",
    "s", "m", "h". 
     When omitted, this means the user has no opinion and the platform is left
    to choose a reasonable default. This default is subject to change over time.
    The current default is 5s.
    
$ oc -n openshift-ingress rsh router-default-6c6b5cf95b-b27nd
sh-4.4$ grep "timeout connect" haproxy.config
  timeout connect 5s

$ oc -n openshift-ingress-operator patch ingresscontroller/default -p '{"spec":{"tuningOptions":{"connectTimeout":"30s"}}}' --type=merge
ingresscontroller.operator.openshift.io/default patched

$ oc -n openshift-ingress get deployment/router-default -oyaml | grep TIMEOUT -A1
        - name: ROUTER_DEFAULT_CONNECT_TIMEOUT
          value: 30s

$ oc -n openshift-ingress rsh router-default-c55b5c64f-b96gh
sh-4.4$ env | grep TIMEOUT 
ROUTER_DEFAULT_CONNECT_TIMEOUT=30s
sh-4.4$ grep "timeout connect" haproxy.config
  timeout connect 30s

[gcs278]

/assign

[knobunc]

/lgtm

[knobunc]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [knobunc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knobunc]

/hold

Pending @gcs278 's review

[gcs278]

I did some sanity checks by recreating the backport, reviewing merge conflicts, and everything looks reasonable.

/unhold
/lgtm

[openshift-ci-robot]

@alebedev87: Jira Issue OCPBUGS-36555: All pull requests linked via external trackers have merged:

• openshift/api#1951
• openshift/cluster-ingress-operator#1105

Jira Issue OCPBUGS-36555 has been moved to the MODIFIED state.

Details

In response to this:

Backport of #1097.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-ingress-operator-container-v4.14.0-202407122009.p0.g992e813.assembly.stream.el8 for distgit ose-cluster-ingress-operator.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.14.0-0.nightly-2024-07-13-005628