[release-4.16] OCPBUGS-34837: Bump openshift/library-go to resolve NewPrometheusClient E2E failures

[openshift-cherrypick-robot]

This is an automated cherry-pick of #1054

/assign gcs278

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-33792 has been cloned as Jira Issue OCPBUGS-34837. Will retitle bug to link to clone.
/retitle [release-4.16] OCPBUGS-34837: Bump openshift/library-go to resolve NewPrometheusClient E2E failures

Details

In response to this:

This is an automated cherry-pick of #1054

/assign gcs278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-34837, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
• expected dependent Jira Issue OCPBUGS-33792 to target a version in 4.17.0, but it targets "4.16.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1054

/assign gcs278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[gcs278]

I want to review the vendor deltas before pushing this through.
/hold

[openshift-ci]

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[gcs278]

Since this has the same deltas as #1054, it feels safe to me.
/unhold

[candita]

@gcs278 I saw your original bump had a manual change documented as being in MakeServerCert: #1054 (comment), but it's actually a manual change in desiredRouterDefaultCertificateSecret. This should probably be noted there or here or both.

Update: never mind, I guess I misread it. For the record, the change is to use a Set rather than string for hostnames.

[candita]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: candita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [candita]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[candita]

This backport fixes an issue introduced in 4.16 with openshift/library-go#1697 and is needed in order for prometheus and any CI based on prometheus to work properly.

/backport-risk-assessed

[candita]

This backport is low risk and fixes an issue introduced in 4.16 with openshift/library-go#1697 and is needed in order for prometheus and any CI based on prometheus to work properly.

/label backport-risk-assessed

[candita]

/jira refresh

[openshift-ci-robot]

@candita: This pull request references Jira Issue OCPBUGS-34837, which is invalid:

• expected dependent Jira Issue OCPBUGS-33792 to target a version in 4.17.0, but it targets "4.16.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[candita]

/jira refresh

[openshift-ci-robot]

@candita: This pull request references Jira Issue OCPBUGS-34837, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-33792 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-33792 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
• bug has dependents

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lihongan]

/label qe-approved
/label cherry-pick-approved

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-34837, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-33792 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-33792 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
• bug has dependents

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

This is an automated cherry-pick of #1054

/assign gcs278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-34837: All pull requests linked via external trackers have merged:

• openshift/cluster-ingress-operator#1074

Jira Issue OCPBUGS-34837 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #1054

/assign gcs278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-ingress-operator-container-v4.16.0-202406050206.p0.g228ed46.assembly.stream.el9 for distgit ose-cluster-ingress-operator.
All builds following this will include this PR.