Use credentials from cloud-credential-operator#106
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Jan 31, 2019
Merged
Conversation
Replace use of kube-system cloud credentials by using openshift-ingress cloud credentials courtesy of cloud-credential-operator. This commit resolves NE-140. https://jira.coreos.com/browse/NE-140 * cmd/cluster-ingress-operator/main.go (cloudCredentialsSecretName): New constant with the name of the cloud credentials secret that cloud-credential-operator creates for cluster-ingress-operator. (main): Pass operatorNamespace to createDNSManager. (createDNSManager): Instead of using the "aws-creds" secret from the "kube-system" namespace, use the "cloud-credentials" secret from the operator's namespace. * manifests/01-kube-system-aws-creds-role-binding.yaml: Deleted; the operator no longer needs to read the secret from the kube-system namespace.
openshift-ci-robot
added
size/S
Contributor
|
Should hopefully see wildcard DNS test fail in e2e-aws now... /retest |
Contributor
|
/retest |
1 similar comment
Contributor
|
/retest |
Contributor
|
/lgtm |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest |
1 similar comment
Contributor
|
/retest |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, Miciah, pravisankar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/retest |
4 similar comments
Contributor
|
/retest |
Contributor
|
/retest |
Contributor
|
/retest |
Contributor
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace use of kube-system cloud credentials by using openshift-ingress cloud credentials courtesy of cloud-credential-operator.
This PR resolves NE-140.
This PR depends on openshift/cloud-credential-operator#16.
cmd/cluster-ingress-operator/main.go(cloudCredentialsSecretName): New constant with the name of the cloud credentials secret that cloud-credential-operator creates for cluster-ingress-operator.(
main): PassoperatorNamespacetocreateDNSManager.(
createDNSManager): Instead of using theaws-credssecret from thekube-systemnamespace, use thecloud-credentialssecret from the operator's namespace.manifests/01-kube-system-aws-creds-role-binding.yaml: Deleted; the operator no longer needs to read the secret from thekube-systemnamespace.