Skip to content

OCPBUGS-28673: implement connect timeout tuning option #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Apr 22, 2024
Merged

OCPBUGS-28673: implement connect timeout tuning option #1035

openshift-merge-bot merged 2 commits into from
Apr 22, 2024

Conversation

@alebedev87
Copy link
Contributor

@alebedev87 alebedev87 commented Mar 26, 2024 •
edited
Loading

This PR implements the connect timeout tuning option. The corresponding API PR: openshift/api#1829.

Also, the way the CRDs are copied from the vendored API has changed. The IngressController and DNSRecord CRDs were moved to dedicated packages following the introduction of a new method for generating CRDs in the OpenShift API (openshift/api#1803). This PR adds these new packages as tool imports to make use of the go.mod versioning and to be able to go get them before copying into manifests directory.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 26, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 26, 2024

@alebedev87: This pull request references Jira Issue OCPBUGS-28673, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR implements the connect timeout tuning option.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from gcs278 and miheer March 26, 2024 13:29
@alebedev87 alebedev87 changed the title OCPBUGS-28673: implement connect timeout tuning option [WIP] OCPBUGS-28673: implement connect timeout tuning option Mar 26, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2024
@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 5, 2024
Merged
@alebedev87 alebedev87 force-pushed the connect-timeout branch 2 times, most recently from dfff547 to 08b1b2a Compare April 5, 2024 20:41
@alebedev87 alebedev87 changed the title [WIP] OCPBUGS-28673: implement connect timeout tuning option OCPBUGS-28673: implement connect timeout tuning option Apr 15, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2024
@alebedev87
Copy link
Contributor Author

alebedev87 commented Apr 16, 2024

/retest

2 similar comments
@alebedev87
Copy link
Contributor Author

alebedev87 commented Apr 16, 2024

/retest

@alebedev87
Copy link
Contributor Author

alebedev87 commented Apr 16, 2024

/retest

@rfredette
Copy link
Contributor

rfredette commented Apr 17, 2024

/assign

@alebedev87
Copy link
Contributor Author

alebedev87 commented Apr 18, 2024

/hold

Let's hold this PR until #1045 is merged. This way the update generated CRD problem will be addressed separately from the connect timeout bug.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
@alebedev87
Copy link
Contributor Author

alebedev87 commented Apr 18, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
@alebedev87
Copy link
Contributor Author

alebedev87 commented Apr 22, 2024

/retest

@rfredette
Copy link
Contributor

rfredette commented Apr 22, 2024

/approve
/lgtm
Thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfredette

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 22, 2024

/retest-required

Remaining retests: 0 against base HEAD bca2dff and 2 for PR HEAD 15785bf in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

@alebedev87: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn 15785bf link false /test e2e-azure-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b7d42a2 into openshift:master Apr 22, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 22, 2024

@alebedev87: Jira Issue OCPBUGS-28673: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28673 has been moved to the MODIFIED state.

Details

In response to this:

This PR implements the connect timeout tuning option. The corresponding API PR: openshift/api#1829.

Also, the way the CRDs are copied from the vendored API has changed. The IngressController and DNSRecord CRDs were moved to dedicated packages following the introduction of a new method for generating CRDs in the OpenShift API (openshift/api#1803). This PR adds these new packages as tool imports to make use of the go.mod versioning and to be able to go get them before copying into manifests directory.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 23, 2024

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-ingress-operator-container-v4.16.0-202404222343.p0.gb7d42a2.assembly.stream.el9 for distgit ose-cluster-ingress-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Apr 26, 2024

Fix included in accepted release 4.16.0-0.nightly-2024-04-26-145258

@alebedev87 alebedev87 mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gcs278 gcs278 Awaiting requested review from gcs278

@miheer miheer Awaiting requested review from miheer

Assignees

@rfredette rfredette

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alebedev87 @openshift-ci-robot @rfredette @openshift-bot @openshift-merge-robot