Improve error handling in private zone discovery#100
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Jan 11, 2019
Merged
Conversation
openshift-ci-robot
added
the
size/XS
Follow-up to commit 2526a4c. * pkg/dns/aws/dns.go (discoverZones): Use kerrors.NewAggregate to combine error values from GetResourcesPages and its callback.
openshift-ci-robot
added
the
approved
Miciah
force-pushed
the
improve-error-handling-in-private-zone-discovery
branch
from
dde542e to
eea402f
Compare
ironcladlou
reviewed
Jan 11, 2019
| err = innerError | ||
| } | ||
| if err != nil { | ||
| if err := kerrors.NewAggregate([]error{innerError, outerError}); err != nil { |
Contributor
There was a problem hiding this comment.
Wonder why this doesn't take varargs 🤨
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
/retest |
Contributor
Author
|
For the record, I checked the operator's logs from the e2e-aws-operator job, and the "failed to discover hosted zones: couldn't find private hosted zone" errors are gone. (I wanted to check the logs on #99, but it merged before I had the chance to look at the logs from a successful test run.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #99.
pkg/dns/aws/dns.go(discoverZones): Usekerrors.NewAggregateto combine error values from GetResourcesPages and its callback.