Skip to content

Comments

Set user tags on s3 bucket#84

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
coreydaley:set_user_tags_on_s3_bucket
Nov 27, 2018
Merged

Set user tags on s3 bucket#84
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
coreydaley:set_user_tags_on_s3_bucket

Conversation

@coreydaley
Copy link

@coreydaley coreydaley commented Nov 26, 2018

  • Set installConfig.Platform.AWS.UserTags as tags on the created S3 bucket

@coreydaley coreydaley requested review from dmage and legionus November 26, 2018 22:00
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 26, 2018
@coreydaley
Copy link
Author

/assign @legionus @dmage

@bparees
Copy link
Contributor

bparees commented Nov 26, 2018

@coreydaley please split this into two PRs, one for the usertags and the other for the managedstorage status field.

@coreydaley
Copy link
Author

Will split it up in the next push

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 27, 2018
@bparees
Copy link
Contributor

bparees commented Nov 27, 2018

@coreydaley please split this into two PRs, one for the usertags and the other for the managedstorage status field.

Will split it up in the next push

separate commits!=separate PRs. I was trying to help you expedite the merge since i expect the usertags PR to be less controversial than whatever discussion needs to happen around how we want to represent the ManagedStorage status.

anyway add the nil checking that @wking suggested and i think this is lgtm, but i guess we'll see if @legionus or @dmage have any concerns on the ManagedStorage status field.

@coreydaley coreydaley changed the title Set user tags on s3 bucket and set ManagedStorage on CR Set user tags on s3 bucket Nov 27, 2018
@coreydaley
Copy link
Author

@bparees I split this into two PRs now. ptal

@bparees
Copy link
Contributor

bparees commented Nov 27, 2018

/lgtm

thanks @coreydaley

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, coreydaley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2018
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit add05f5 into openshift:master Nov 27, 2018
@coreydaley coreydaley deleted the set_user_tags_on_s3_bucket branch August 14, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants