DEVEXP-402: Mount trusted-ca to registry base pki trust source#360
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Aug 23, 2019
Merged
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
adambkaplan
force-pushed
the
registry-trusted-ca
branch
from
2069fe7 to
4e89c37
Compare
adambkaplan
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
/hold Blocked by #340 |
openshift-ci-robot
added
the
do-not-merge/hold
Contributor
Author
|
/retest s3 issue from earlier today |
dmage
reviewed
Aug 20, 2019
Contributor
Author
|
/retest |
Contributor
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Contributor
|
/lgtm |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
Author
|
/hold I may not be mounting the trust correctly |
openshift-ci-robot
added
do-not-merge/hold
adambkaplan
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
Contributor
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Ensures that no other base trust is present for the registry.
adambkaplan
force-pushed
the
registry-trusted-ca
branch
from
d8a3263 to
8765862
Compare
adambkaplan
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
@dmage ready for review again |
Contributor
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
coreydaley
reviewed
Aug 23, 2019
| configapiv1 "github.com/openshift/api/config/v1" | ||
| configlisters "github.com/openshift/client-go/config/listers/config/v1" | ||
| "github.com/openshift/cluster-image-registry-operator/pkg/apis/imageregistry/v1" | ||
| v1 "github.com/openshift/cluster-image-registry-operator/pkg/apis/imageregistry/v1" |
There was a problem hiding this comment.
This doesn't need an alias, but it won't hurt anything
coreydaley
reviewed
Aug 23, 2019
| func NewFixturesBuilder() *FixturesBuilder { | ||
| factory := &FixturesBuilder{ | ||
| deploymentIndexer: cache.NewIndexer(cache.MetaNamespaceKeyFunc, cache.Indexers{}), | ||
| dsIndexer: cache.NewIndexer(cache.MetaNamespaceKeyFunc, cache.Indexers{}), |
There was a problem hiding this comment.
I think this should be updated to daemonSetsIndexer for clarity
coreydaley
reviewed
Aug 23, 2019
| func TestMakePodTemplateSpec(t *testing.T) { | ||
| // TODO: Make this table-driven to verify all storage drivers | ||
| params := ¶meters.Globals{} | ||
| params.Deployment.Namespace = "openshift-image-registry" |
There was a problem hiding this comment.
v1.ImageRegistryOperatorNamespace instead of a string?
coreydaley
approved these changes
Aug 23, 2019
coreydaley
left a comment
coreydaley
left a comment
There was a problem hiding this comment.
A few small nits but nothing that should prohibit this from merging.
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, coreydaley, dmage The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that no other base trust is present for the registry.