Skip to content

Remove unsupported storages #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 19, 2019
Merged

Remove unsupported storages #257

openshift-merge-robot merged 1 commit into from
Apr 19, 2019

Conversation

@dmage
Copy link
Contributor

@dmage dmage commented Apr 16, 2019 •
edited
Loading

As a part of API stabilization we need to remove unsupported storage backends. Fixes #256.

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 16, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2019
adambkaplan
adambkaplan reviewed Apr 16, 2019
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Need @openshift/api-reviewers input on experimental support for Swift

@adambkaplan
Copy link
Contributor

adambkaplan commented Apr 16, 2019

@FlorinPeter we may need to remove the swift storage configuration that you contributed, as we are not ready to support this until a future release. Is it OK if we move this to a feature branch, or are you using it to install the registry on OpenStack?

@FlorinPeter
Copy link

FlorinPeter commented Apr 16, 2019

@adambkaplan yes I am using this part in OCP4 HTB.
What is the problem with this part?

@tomassedovic I guess you also use this part?

@Fedosin
Copy link
Contributor

Fedosin commented Apr 17, 2019

@adambkaplan hi! I think it's okay to remove Swift storage for a while. I'll rebase my PR #211 in that case.

adambkaplan
adambkaplan reviewed Apr 17, 2019
View reviewed changes
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 17, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 17, 2019
@dmage
Copy link
Contributor Author

dmage commented Apr 17, 2019

@adambkaplan ptal

adambkaplan
adambkaplan suggested changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits on the godoc.

pkg/apis/imageregistry/v1/types.go Outdated
// S3 represents configuration that uses Amazon Simple Storage Service.
S3 *ImageRegistryConfigStorageS3 `json:"s3,omitempty"`
// Swift represents experimental configuration that uses OpenStack Object
// Storage.
Copy link
Contributor

@adambkaplan adambkaplan Apr 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Storage.
// Swift represents configuration that uses OpenStack Object Storage.
// This configuration is EXPERIMENTAL and is subject to change without notice.

@adambkaplan
Copy link
Contributor

adambkaplan commented Apr 18, 2019

Per conversation with @dmage and comments in this PR, Swift and EmptyDir storage will both be marked as EXPERIMENTAL APIs, subject to modification or removal in a future release.

adambkaplan
adambkaplan approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 18, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, dmage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit bdd444b into openshift:master Apr 19, 2019
abhinavdahiya added a commit to abhinavdahiya/installer that referenced this pull request Apr 22, 2019
@abhinavdahiya
upi: update the registry patch command
40e0eec 
image-registry operator modified the opertor config object to reduce the supported storage options [1].
This commit updates the docs to follow the new structure

[1]: openshift/cluster-image-registry-operator#257
This was referenced Apr 22, 2019
Merged
Merged
abhinavdahiya added a commit to abhinavdahiya/release that referenced this pull request Apr 22, 2019
@abhinavdahiya
upi: update the registry patch command
8f3c1cc 
image-registry operator modified the opertor config object to reduce the supported storage options [1].
This commit updates the docs to follow the new structure

[1]: openshift/cluster-image-registry-operator#257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coreydaley coreydaley Awaiting requested review from coreydaley

3 more reviewers

@soltysh soltysh soltysh left review comments

@FlorinPeter FlorinPeter FlorinPeter left review comments

@adambkaplan adambkaplan adambkaplan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adambkaplan adambkaplan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[api-freeze] Verify operator API is frozen

8 participants

@dmage @adambkaplan @FlorinPeter @Fedosin @openshift-ci-robot @openshift-bot @soltysh @openshift-merge-robot