Skip to content

Use Cluster Version ClusterID instead of Install Config ClusterID#127

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
coreydaley:cluster_version_update
Dec 19, 2018
Merged

Use Cluster Version ClusterID instead of Install Config ClusterID#127
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
coreydaley:cluster_version_update

Conversation

@coreydaley
Copy link

This is a temporary patch until #106 merges

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 19, 2018
@coreydaley
Copy link
Author

/assign @bparees

@coreydaley
Copy link
Author

@bparees ptal
This will get refactored some in #106

@coreydaley
Copy link
Author

/retest

@coreydaley
Copy link
Author

Failure due to maximum number of VPCs exceeded on AWS
@smarterclayton @bparees fyi

@coreydaley
Copy link
Author

/retest

2 similar comments
@coreydaley
Copy link
Author

/retest

@coreydaley
Copy link
Author

/retest

@bparees
Copy link
Contributor

bparees commented Dec 19, 2018

/lgtm

thanks for jumping on this @coreydaley

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, coreydaley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2018
@openshift-merge-robot openshift-merge-robot merged commit 6d3dfb2 into openshift:master Dec 19, 2018
@coreydaley coreydaley deleted the cluster_version_update branch August 14, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants