Skip to content

Conversation

@tjungblu
Copy link
Contributor

@tjungblu tjungblu commented Oct 5, 2022

The health check is known to hang sometimes since #862 - it might also get stuck on the listing, thus explicitly adding a 10s timeout to the whole operation here instead of context.Background.

Not sure whether that's resolving the issue in openshift/installer#6124 yet.

@openshift-ci openshift-ci bot requested review from EmilyM1 and dusk125 October 5, 2022 09:50
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tjungblu
Once this PR has been reviewed and has the lgtm label, please assign sttts for approval by writing /assign @sttts in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2022

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-five-control-plane-replicas 70319af link false /test e2e-gcp-ovn-five-control-plane-replicas
ci/prow/e2e-agnostic-ovn-upgrade 70319af link true /test e2e-agnostic-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@dusk125 dusk125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, will approve when we get another

@tjungblu
Copy link
Contributor Author

tjungblu commented Oct 5, 2022

/hold

yeah let's wait for a while, even adding that PR doesn't resolve everything.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2022
@tjungblu tjungblu closed this Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants