Skip to content

[WIP] Upgrade library-go version#715

Closed
qJkee wants to merge 2 commits intoopenshift:masterfrom
qJkee:CNF-3684-deps
Closed

[WIP] Upgrade library-go version#715
qJkee wants to merge 2 commits intoopenshift:masterfrom
qJkee:CNF-3684-deps

Conversation

@qJkee
Copy link
Copy Markdown
Contributor

@qJkee qJkee commented Dec 10, 2021

Bumping the library-go dependency to latest, this should take advantage of leader election changes for SNO clusters proposed in this library-go PR and performance improvements in this PR.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 10, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2021
@openshift-ci openshift-ci Bot requested a review from ironcladlou December 10, 2021 17:02
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 10, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: qJkee
To complete the pull request process, please assign hexfusion after the PR has been reviewed.
You can assign the PR to them by writing /assign @hexfusion in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested a review from marun December 10, 2021 17:02
@qJkee qJkee changed the title Upgrade library-go version [WIP] Upgrade library-go version Dec 13, 2021
@qJkee qJkee marked this pull request as ready for review December 13, 2021 18:37
@qJkee
Copy link
Copy Markdown
Contributor Author

qJkee commented Dec 14, 2021

/retest

@damemi
Copy link
Copy Markdown

damemi commented Dec 14, 2021

Hi, just noticed this... you may want to should update this PR to bump all of the dependencies (not just library-go) and k8s as well. We have updated our libraries to 1.23, so you'll need to make updates like this #716 (feel free to close my PR if you want)

The error @hexfusion pointed out is related to the 1.23 bump, and will need to be fixed with a change similar to this in how logging is initialized: openshift/cluster-kube-controller-manager-operator@c339a94

More info on aos-devel https://mailman-int.corp.redhat.com/archives/aos-devel/2021-December/msg00088.html

@qJkee
Copy link
Copy Markdown
Contributor Author

qJkee commented Dec 14, 2021

Hi, just noticed this... you may want to should update this PR to bump all of the dependencies (not just library-go) and k8s as well. We have updated our libraries to 1.23, so you'll need to make updates like this #716 (feel free to close my PR if you want)

The error @hexfusion pointed out is related to the 1.23 bump, and will need to be fixed with a change similar to this in how logging is initialized: openshift/cluster-kube-controller-manager-operator@c339a94

More info on aos-devel https://mailman-int.corp.redhat.com/archives/aos-devel/2021-December/msg00088.html

@damemi all packages are updated as well since it's required by new version of library-go

@damemi
Copy link
Copy Markdown

damemi commented Dec 14, 2021

@qJkee ah, sorry.. I didn't actually look at the changes, just assumed from the PR title (my mistake)

However the logging fix I linked should still help you here. I'll close my other PR

@qJkee
Copy link
Copy Markdown
Contributor Author

qJkee commented Dec 15, 2021

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 15, 2021

@qJkee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-five-control-plane-replicas f5f8171 link false /test e2e-gcp-five-control-plane-replicas
ci/prow/verify-deps f5f8171 link true /test verify-deps
ci/prow/e2e-aws-single-node f5f8171 link true /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hexfusion
Copy link
Copy Markdown
Contributor

@qJkee I appreciate the PR but as this bump is time sensitive I needed to get it merged. Looks like it's just a dep issue at this point. Sorry and Thanks!

superseded by #718

@hexfusion hexfusion closed this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants