[WIP] Upgrade library-go version#715
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: qJkee The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
|
One of the deps breaks the operator ? |
|
Hi, just noticed this... you The error @hexfusion pointed out is related to the 1.23 bump, and will need to be fixed with a change similar to this in how logging is initialized: openshift/cluster-kube-controller-manager-operator@c339a94 More info on aos-devel https://mailman-int.corp.redhat.com/archives/aos-devel/2021-December/msg00088.html |
@damemi all packages are updated as well since it's required by new version of library-go |
|
@qJkee ah, sorry.. I didn't actually look at the changes, just assumed from the PR title (my mistake) However the logging fix I linked should still help you here. I'll close my other PR |
|
/retest |
|
@qJkee: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Bumping the library-go dependency to latest, this should take advantage of leader election changes for SNO clusters proposed in this library-go PR and performance improvements in this PR.