Skip to content

Conversation

@markmc
Copy link
Contributor

@markmc markmc commented Jul 29, 2020

This is just some early-stage hacking to see a render command for an all-in-one config might look like.

As such this is related to openshift/enhancements#302 but a much hackier approach to what's described there.

markmc added 7 commits July 29, 2020 12:27
Separate out the byte-array level etcd cert signing from the
kube-resources level. Paves the way for rendering these certs directly
to files.
Demonstrate the idea of reusing CEO code to generate aio static pod
assets, but short-cutting anything involving talking to the API
server.
It appears OPERATOR_IMAGE_SPEC and VERBOSITY were never used.
Allow it to be used for aio rendering, without reusing the full
controller.
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2020
@markmc
Copy link
Contributor Author

markmc commented Jul 29, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markmc
To complete the pull request process, please assign hexfusion
You can assign the PR to them by writing /assign @hexfusion in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hexfusion
Copy link
Contributor

cc @ironcladlou

@ironcladlou
Copy link
Contributor

@markmc thanks for putting this together! Your work here with certificate rendering actually intersects with some tech debt we've been meaning to pay down in bootstrapping, which currently generates certificates using a potentially flaky client/server model that's now unnecessary.

I need to open a separate set of PRs for that work (in the operator and the installer) and I'll keep your PR in mind while doing so (I haven't had a chance to look closely at what you've done, it's possible you may have given me a head start).

Once I have a WIP going I'll link it to this PR. I want to make sure what I'm doing is reusable in the context of your AIO goals.

@openshift-ci-robot
Copy link

@markmc: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2020
@openshift-ci-robot
Copy link

@markmc: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-upgrade 6690f75 link /test e2e-gcp-upgrade
ci/prow/e2e-gcp 6690f75 link /test e2e-gcp
ci/prow/e2e-aws-disruptive 6690f75 link /test e2e-aws-disruptive
ci/prow/e2e-operator 6690f75 link /test e2e-operator
ci/prow/e2e 6690f75 link /test e2e
ci/prow/e2e-upgrade 6690f75 link /test e2e-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@markmc
Copy link
Contributor Author

markmc commented Sep 9, 2020

Work along these lines is happening at openshift/enhancements#440 now

@markmc markmc closed this Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants