-
Notifications
You must be signed in to change notification settings - Fork 149
WIP: experiment with a render command for an all-in-one config #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Separate out the byte-array level etcd cert signing from the kube-resources level. Paves the way for rendering these certs directly to files.
Demonstrate the idea of reusing CEO code to generate aio static pod assets, but short-cutting anything involving talking to the API server.
It appears OPERATOR_IMAGE_SPEC and VERBOSITY were never used.
Allow it to be used for aio rendering, without reusing the full controller.
|
/hold |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: markmc The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
cc @ironcladlou |
|
@markmc thanks for putting this together! Your work here with certificate rendering actually intersects with some tech debt we've been meaning to pay down in bootstrapping, which currently generates certificates using a potentially flaky client/server model that's now unnecessary. I need to open a separate set of PRs for that work (in the operator and the installer) and I'll keep your PR in mind while doing so (I haven't had a chance to look closely at what you've done, it's possible you may have given me a head start). Once I have a WIP going I'll link it to this PR. I want to make sure what I'm doing is reusable in the context of your AIO goals. |
|
@markmc: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@markmc: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Work along these lines is happening at openshift/enhancements#440 now |
This is just some early-stage hacking to see a render command for an all-in-one config might look like.
As such this is related to openshift/enhancements#302 but a much hackier approach to what's described there.