Bug 1846574: bindata/bootkube/bootstrap-manifests: add proper env to metrics container on bootstrap.

[hexfusion]

Signed-off-by: Sam Batschelet sbatsche@redhat.com

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [hexfusion]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@hexfusion: This pull request references Bugzilla bug 1846574, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1846574: bindata/bootkube/bootstrap-manifests: add proper env to metrics container on bootstrap.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ironcladlou]

What job will verify this?

[hexfusion]

What job will verify this?

none

[hexfusion]

@ironcladlou we should consider another action item from this.

As monitoring does not actually harvest bootstrap etcd metrics.

• should/can it?
• depending on above should we just save resources and remove the container altogether.

[openshift-ci-robot]

@hexfusion: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-azure	6787d50	link	/test e2e-azure
ci/prow/e2e-aws-disruptive	6787d50	link	/test e2e-aws-disruptive
ci/prow/e2e-aws-operator	6787d50	link	/test e2e-aws-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@hexfusion: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hexfusion]

This PR is no longer necessary as we removed the metrics container from bootstrap all together in #416

[openshift-ci-robot]

@hexfusion: This pull request references Bugzilla bug 1846574. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1846574: bindata/bootkube/bootstrap-manifests: add proper env to metrics container on bootstrap.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.