Bug 1919737: Set CoreDNS readiness probe period and timeout each to 3 seconds #234
Conversation
Change the readiness probe for CoreDNS from using a 10-second period and timeout to using a 3-second period and timeout in order to reduce the time to remove the endpoint if CoreDNS becomes unresponsive. This commit is related to bug 1919737. https://bugzilla.redhat.com/show_bug.cgi?id=1919737 * assets/dns/daemonset.yaml: Set readiness probe period and timeout to 3 seconds. * pkg/manifests/bindata.go: Regenerate.
Check all parameters of the CoreDNS daemonset's readiness probe, and update the daemonset if any of the probe's parameters differ from the expected values. Before this commit, the DNS controller only reconciled the readiness probe's handler and ignored changes to other parameters of the probe. * pkg/operator/controller/controller_dns_daemonset.go (daemonsetConfigChanged): Check if any of the readiness probe's parameters changed and update them if they did. * pkg/operator/controller/controller_dns_daemonset_test.go (TestDaemonsetConfigChanged): Add test case to verify that daemonsetConfigChanged detects changes to the readiness probe's periodSeconds parameter.
|
@Miciah: This pull request references Bugzilla bug 1919737, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-urgent
openshift-ci-robot
added
the
approved
|
I like this. I'd lgtm, but want other people to consider too. |
|
I see some lookup failures in the last e2e-upgrade CI job run, and Meanwhile, must-gather failed on the last e2e-aws CI job run because DNS wasn't working, which is concerning. Must-gather is known to be flaky, but the DNS failures are concerning, so let's keep an eye on that. |
|
e2e-upgrade passed, and e2e-aws failed with errors related to sandbox initialization and nothing obviously related to DNS. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.7 |
|
@Miciah: once the present PR merges, I will cherry-pick it on top of release-4.7 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.6 |
|
@Miciah: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Miciah: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1919737 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Miciah: new pull request created: #235 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Miciah: #234 failed to apply on top of branch "release-4.6": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
Set CoreDNS readiness probe period and timeout to 3 seconds
Change the readiness probe for CoreDNS from using a 10-second period and timeout to using a 3-second period and timeout in order to reduce the time to remove the endpoint if CoreDNS becomes unresponsive.
assets/dns/daemonset.yaml: Set readiness probe period and timeout to 3 seconds.pkg/manifests/bindata.go: Regenerate.Reconcile all readiness probe parameters
Check all parameters of the CoreDNS daemonset's readiness probe, and update the daemonset if any of the probe's parameters differ from the expected values.
Before this commit, the DNS controller only reconciled the readiness probe's handler and ignored changes to other parameters of the probe.
pkg/operator/controller/controller_dns_daemonset.go(daemonsetConfigChanged): Check if any of the readiness probe's parameters changed and update them if they did.pkg/operator/controller/controller_dns_daemonset_test.go(TestDaemonsetConfigChanged): Add test case to verify thatdaemonsetConfigChangeddetects changes to the readiness probe'speriodSecondsparameter.