Bug 1905323: Request appropriate memory for dns-node-resolver container #225

rfredette · 2020-12-15T17:22:17Z

Cluster components are expected to request cpu & memory resources. dns-node-resolver already requested an amount of cpu time, but didn't include a memory request.

Following the guidelines here, I ran make test-e2e against a cluster on AWS running a 4.7 nightly build. I queried prometheus for the metric container_memory_usage_bytes{container="dns-node-resolver"} every 15 seconds between the start and finish of the e2e run, then I sorted the data points by memory usage to find the 90th percentile.

I'm not sure why, but there was a spread of about 13MiB of memory used between different dns-node-resolver containers in the daemonset. Looking at all the containers as a single set, the 90th percentile memory usage was 11,239,424 bytes, but one of the individual containers had a 90th percentile memory usage of 19,963,904 bytes, or about 19MiB. I chose to use the 90th percentile number from the individual container.

Adding 10% overhead to that number produced 20.94MiB, which I rounded to 21MiB.

openshift-ci-robot · 2020-12-15T17:22:22Z

@rfredette: An error was encountered adding this pull request to the external tracker bugs for bug 1905323 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 32000: There was an error reported for the RPC call to Jira: There was an error reported for a GitHub REST call. URL: https://api.github.com/repos/openshift/cluster-dns-operator/pulls/225 Error: 403 Forbidden at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. eval {...} called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 98 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559586...', 'https://api.github.com/repos/openshift/cluster-dns-operator/p...', 'GET') called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559586...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559587d0afe0)') called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559587d0afe0)', 1) called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x5595897aaf88)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 940 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x55958d784260)', 'HASH(0x55958bd76fa0)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x55958bd76fa0)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1173 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x559585b81ef8)') called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559588894b48)') called at (eval 3004) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55958d349718)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 297 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55958d349718)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x55958e349878)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x5595869783d8)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x5595869783d8)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x55958e349878)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x55958e349878)') called at (eval 3004) line 0 eval {...} called at (eval 3004) line 0 at /var/www/html/bugzilla/Bugzilla/Error.pm line 130. Bugzilla::Error::_throw_error('global/user-error.html.tmpl', 'ext_bz_rest_error', 'HASH(0x5595896e2448)') called at /var/www/html/bugzilla/Bugzilla/Error.pm line 193 Bugzilla::Error::ThrowUserError('ext_bz_rest_error', 'HASH(0x5595896e2448)') called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 120 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559586...', 'https://api.github.com/repos/openshift/cluster-dns-operator/p...', 'GET') called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559586...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559587d0afe0)') called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559587d0afe0)', 1) called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x5595897aaf88)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 940 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x55958d784260)', 'HASH(0x55958bd76fa0)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x55958bd76fa0)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1173 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x559585b81ef8)') called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559588894b48)') called at (eval 3004) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55958d349718)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 297 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55958d349718)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x55958e349878)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x5595869783d8)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x5595869783d8)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x55958e349878)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x55958e349878)') called at (eval 3004) line 0 eval {...} called at (eval 3004) line 0
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 1905323: Request appropriate memory for dns-node-resolver container

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sgreene570 · 2020-12-15T17:33:47Z

/bugzilla refresh

openshift-ci-robot · 2020-12-15T17:33:50Z

@sgreene570: An error was encountered adding this pull request to the external tracker bugs for bug 1905323 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 32000: There was an error reported for the RPC call to Jira: There was an error reported for a GitHub REST call. URL: https://api.github.com/repos/openshift/cluster-dns-operator/pulls/225 Error: 403 Forbidden at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. eval {...} called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 98 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x55958d...', 'https://api.github.com/repos/openshift/cluster-dns-operator/p...', 'GET') called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x55958d...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x55958b0c8630)') called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x55958b0c8630)', 1) called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x55958c9b34e8)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 940 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x55958c374e98)', 'HASH(0x55958b237480)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x55958b237480)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1173 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x5595860ca3b8)') called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55958b197b10)') called at (eval 3556) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559588874620)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 297 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559588874620)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x559585657470)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x559586ee5e48)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x559586ee5e48)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559585657470)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559585657470)') called at (eval 3556) line 0 eval {...} called at (eval 3556) line 0 at /var/www/html/bugzilla/Bugzilla/Error.pm line 130. Bugzilla::Error::_throw_error('global/user-error.html.tmpl', 'ext_bz_rest_error', 'HASH(0x5595881c5f98)') called at /var/www/html/bugzilla/Bugzilla/Error.pm line 193 Bugzilla::Error::ThrowUserError('ext_bz_rest_error', 'HASH(0x5595881c5f98)') called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 120 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x55958d...', 'https://api.github.com/repos/openshift/cluster-dns-operator/p...', 'GET') called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x55958d...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x55958b0c8630)') called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x55958b0c8630)', 1) called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x55958c9b34e8)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 940 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x55958c374e98)', 'HASH(0x55958b237480)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x55958b237480)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1173 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x5595860ca3b8)') called at /loader/0x5595817be1f0/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55958b197b10)') called at (eval 3556) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559588874620)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 297 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559588874620)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x559585657470)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x559586ee5e48)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x559586ee5e48)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559585657470)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559585657470)') called at (eval 3556) line 0 eval {...} called at (eval 3556) line 0
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rfredette · 2020-12-15T21:00:41Z

/bugzilla refresh

openshift-ci-robot · 2020-12-15T21:00:47Z

@rfredette: This pull request references Bugzilla bug 1905323, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rfredette · 2020-12-15T21:01:14Z

/retest

lihongan · 2020-12-16T01:52:43Z

/bugzilla cc-qa

openshift-ci-robot · 2020-12-16T01:52:46Z

@lihongan: This pull request references Bugzilla bug 1905323, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lihongan · 2020-12-16T02:58:03Z

@rfredette seems the dns-operator container also didn't include a memory request.

# oc -n openshift-dns-operator get deployment/dns-operator -oyaml
<---snip--->
        name: dns-operator
        resources:
          requests:
            cpu: 10m

could you have a double check?

rfredette · 2020-12-16T15:57:39Z

@lihongan you are correct, dns-operator is missing a memory request. I'll add that to this PR today.

sgreene570 · 2020-12-17T20:11:26Z

/test e2e-aws-operator

Miciah · 2020-12-18T04:28:11Z

/test e2e-aws-operator

openshift-merge-robot · 2020-12-18T05:22:20Z

@rfredette: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-upgrade	`7fb1cb3`	link	`/test e2e-upgrade`
ci/prow/e2e-aws-operator	`7fb1cb3`	link	`/test e2e-aws-operator`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sgreene570 · 2020-12-18T16:44:16Z

/retest

rfredette · 2020-12-18T18:02:16Z

/retest

rfredette · 2021-01-04T17:34:33Z

/retest

sgreene570 · 2021-01-04T18:40:15Z

@rfredette #226 will resolve the failures seen on e2e-aws-operator.

Miciah · 2021-01-05T16:03:28Z

/test e2e-aws-operator
now that #226 has merged.

Miciah · 2021-01-05T19:15:48Z

/lgtm
Thanks!

openshift-ci-robot · 2021-01-05T19:16:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, rfredette

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-01-05T20:16:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-05T22:00:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-05T23:17:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2021-01-06T00:38:11Z

@rfredette: All pull requests linked via external trackers have merged:

openshift/cluster-dns-operator#225

Bugzilla bug 1905323 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1905323: Request appropriate memory for dns-node-resolver container

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Update dns-node-resolver to request memory resource

a3fd116

openshift-ci-robot requested review from Miciah and knobunc December 15, 2020 17:22

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 15, 2020

openshift-ci-robot requested a review from lihongan December 16, 2020 01:52

Request memory resource for dns-operator container

7fb1cb3

openshift-ci-robot assigned Miciah Jan 5, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2021

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2021

openshift-merge-robot merged commit 5caa8f8 into openshift:master Jan 6, 2021

Bug 1905323: Request appropriate memory for dns-node-resolver container #225

Bug 1905323: Request appropriate memory for dns-node-resolver container #225

Uh oh!

Conversation

rfredette commented Dec 15, 2020

Uh oh!

openshift-ci-robot commented Dec 15, 2020

Uh oh!

sgreene570 commented Dec 15, 2020

Uh oh!

openshift-ci-robot commented Dec 15, 2020

Uh oh!

rfredette commented Dec 15, 2020

Uh oh!

openshift-ci-robot commented Dec 15, 2020

Uh oh!

rfredette commented Dec 15, 2020

Uh oh!

lihongan commented Dec 16, 2020

Uh oh!

openshift-ci-robot commented Dec 16, 2020

Uh oh!

lihongan commented Dec 16, 2020

Uh oh!

rfredette commented Dec 16, 2020

Uh oh!

sgreene570 commented Dec 17, 2020

Uh oh!

Miciah commented Dec 18, 2020

Uh oh!

openshift-merge-robot commented Dec 18, 2020

Uh oh!

sgreene570 commented Dec 18, 2020

Uh oh!

rfredette commented Dec 18, 2020

Uh oh!

rfredette commented Jan 4, 2021

Uh oh!

sgreene570 commented Jan 4, 2021

Uh oh!

Miciah commented Jan 5, 2021

Uh oh!

Miciah commented Jan 5, 2021

Uh oh!

openshift-ci-robot commented Jan 5, 2021

Uh oh!

openshift-bot commented Jan 5, 2021

Uh oh!

openshift-bot commented Jan 5, 2021

Uh oh!

openshift-bot commented Jan 5, 2021

Uh oh!

openshift-ci-robot commented Jan 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants