Skip to content

add current profile annotations to CVO manifests #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 27, 2020
Merged

add current profile annotations to CVO manifests #61

openshift-merge-robot merged 1 commit into from
Oct 27, 2020

Conversation

@guillaumerose
Copy link
Contributor

@guillaumerose guillaumerose commented Oct 22, 2020

This is matches openshift/enhancements#414 and doesn't change existing behavior

@guillaumerose
Copy link
Contributor Author

guillaumerose commented Oct 22, 2020

/test unit

deads2k
deads2k reviewed Oct 23, 2020
View reviewed changes
@guillaumerose
add current profile annotations to CVO manifests
2917a40 
This is matches openshift/enhancements#414 and doesn't change existing behavior
@deads2k
Copy link
Contributor

deads2k commented Oct 26, 2020

This is consistent with our default opt-in profile

/lgtm

/assign @jsafrane

for approval.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2020
@jsafrane
Copy link
Contributor

jsafrane commented Oct 26, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guillaumerose, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 415f271 into openshift:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k deads2k left review comments

@gnufied gnufied Awaiting requested review from gnufied

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@jsafrane jsafrane

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@guillaumerose @deads2k @jsafrane @openshift-ci-robot @openshift-bot @openshift-merge-robot