STOR-1700: Pass VolumeGroupSnapshot argument if feature is enabled #191

bertinatto · 2024-02-01T21:35:51Z

CC @openshift/storage

openshift-ci-robot · 2024-02-01T21:35:54Z

@bertinatto: This pull request references STOR-1700 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-02-01T21:37:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [bertinatto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bertinatto · 2024-02-02T00:14:10Z

/retest

bertinatto · 2024-02-05T12:40:19Z

/test images

bertinatto · 2024-02-05T13:49:26Z

/test e2e-gcp-csi

openshift-ci-robot · 2024-02-07T17:08:42Z

@bertinatto: This pull request references STOR-1700 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

Details

In response to this:

CC @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

First of all, check if the VolumeGroupSnapshot feature is enabled in the featuregates. If the feature is enabled, a hook function adds the right cli arguments to enable the feature when starting both the webhook and the snapshot-controller.

bertinatto · 2024-02-08T12:46:09Z

/test images

jsafrane · 2024-02-09T11:11:48Z

/lgtm

jsafrane · 2024-02-09T11:12:27Z

/test all

jsafrane · 2024-02-09T13:44:31Z

failed to create secret: secrets "e2e-gcp-csi" already exists

¯_(ツ)_/¯
/retest-required

jsafrane · 2024-02-09T14:57:12Z

/lgtm

bertinatto · 2024-02-09T18:14:12Z

/retest

openshift-ci · 2024-02-09T19:51:44Z

@bertinatto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

lpettyjo · 2024-02-12T14:06:28Z

/docs-approved

Phaow · 2024-02-12T15:56:01Z

/label qe-approved
Pre verify passed with pre merged build 4.16.0-0.test-2024-02-12-131728-ci-ln-2f6mr7b-latest (build 4.16,openshift/cluster-csi-snapshot-controller-operator#191)

Install a cluster check cluster snapshot operator is healthy and the volumegroupsnapshot is not enabled by default.

$ oc logs csi-snapshot-controller-operator-5b7fb787b7-659hj | grep 'FeatureGates'
I0212 15:34:00.001795       1 event.go:364] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-cluster-storage-operator", Name:"csi-snapshot-controller-operator", UID:"3b21be4a-aaf9-440f-b1c1-06e6c2d165b3", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'FeatureGatesInitialized' FeatureGates updated to featuregates.Features{Enabled:[]v1.FeatureGateName{"AdminNetworkPolicy", "AlibabaPlatform", "AutomatedEtcdBackup", "AzureWorkloadIdentity", "BuildCSIVolumes", "CSIDriverSharedResource", "CloudDualStackNodeIPs", "DNSNameResolver", "DynamicResourceAllocation", "ExternalCloudProvider", "ExternalCloudProviderAzure", "ExternalCloudProviderExternal", "ExternalCloudProviderGCP", "GCPClusterHostedDNS", "GCPLabelsTags", "GatewayAPI", "InsightsConfigAPI", "InstallAlternateInfrastructureAWS", "KMSv1", "MachineAPIProviderOpenStack", "MachineConfigNodes", "ManagedBootImages", "MaxUnavailableStatefulSet", "MetricsServer", "MixedCPUsAllocation", "NetworkLiveMigration", "NodeSwap", "OnClusterBuild", "OpenShiftPodSecurityAdmission", "PinnedImages", "PrivateHostedZoneAWS", "RouteExternalCertificate", "SignatureStores", "SigstoreImageVerification", "TranslateStreamCloseWebsocketRequests", "UpgradeStatus", "VSphereControlPlaneMachineSet", "VSphereStaticIPs", "ValidatingAdmissionPolicy", "VolumeGroupSnapshot"}, Disabled:[]v1.FeatureGateName{"ClusterAPIInstall", "DisableKubeletCloudCredentialProviders", "EventedPLEG", "MachineAPIOperatorDisableMachineHealthCheckController"}}
$ oc get crd| grep volumegroupsnapshot

Enable the feature gate, checked the volumegroupsnapshot crd created as expected, and the args added to the csi-snapshot-webhook and csi-snapshot-controller.

$ oc logs csi-snapshot-controller-operator-5b7fb787b7-659hj | grep 'FeatureGates'
I0212 15:34:00.001795       1 event.go:364] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-cluster-storage-operator", Name:"csi-snapshot-controller-operator", UID:"3b21be4a-aaf9-440f-b1c1-06e6c2d165b3", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'FeatureGatesInitialized' FeatureGates updated to featuregates.Features{Enabled:[]v1.FeatureGateName{"AdminNetworkPolicy", "AlibabaPlatform", "AutomatedEtcdBackup", "AzureWorkloadIdentity", "BuildCSIVolumes", "CSIDriverSharedResource", "CloudDualStackNodeIPs", "DNSNameResolver", "DynamicResourceAllocation", "ExternalCloudProvider", "ExternalCloudProviderAzure", "ExternalCloudProviderExternal", "ExternalCloudProviderGCP", "GCPClusterHostedDNS", "GCPLabelsTags", "GatewayAPI", "InsightsConfigAPI", "InstallAlternateInfrastructureAWS", "KMSv1", "MachineAPIProviderOpenStack", "MachineConfigNodes", "ManagedBootImages", "MaxUnavailableStatefulSet", "MetricsServer", "MixedCPUsAllocation", "NetworkLiveMigration", "NodeSwap", "OnClusterBuild", "OpenShiftPodSecurityAdmission", "PinnedImages", "PrivateHostedZoneAWS", "RouteExternalCertificate", "SignatureStores", "SigstoreImageVerification", "TranslateStreamCloseWebsocketRequests", "UpgradeStatus", "VSphereControlPlaneMachineSet", "VSphereStaticIPs", "ValidatingAdmissionPolicy", "VolumeGroupSnapshot"}, Disabled:[]v1.FeatureGateName{"ClusterAPIInstall", "DisableKubeletCloudCredentialProviders", "EventedPLEG", "MachineAPIOperatorDisableMachineHealthCheckController"}}
I0212 15:34:00.001877       1 starter.go:148] FeatureGates initialized: knownFeatureGates=[AdminNetworkPolicy AlibabaPlatform AutomatedEtcdBackup AzureWorkloadIdentity BuildCSIVolumes CSIDriverSharedResource CloudDualStackNodeIPs ClusterAPIInstall DNSNameResolver DisableKubeletCloudCredentialProviders DynamicResourceAllocation EventedPLEG ExternalCloudProvider ExternalCloudProviderAzure ExternalCloudProviderExternal ExternalCloudProviderGCP GCPClusterHostedDNS GCPLabelsTags GatewayAPI InsightsConfigAPI InstallAlternateInfrastructureAWS KMSv1 MachineAPIOperatorDisableMachineHealthCheckController MachineAPIProviderOpenStack MachineConfigNodes ManagedBootImages MaxUnavailableStatefulSet MetricsServer MixedCPUsAllocation NetworkLiveMigration NodeSwap OnClusterBuild OpenShiftPodSecurityAdmission PinnedImages PrivateHostedZoneAWS RouteExternalCertificate SignatureStores SigstoreImageVerification TranslateStreamCloseWebsocketRequests UpgradeStatus VSphereControlPlaneMachineSet VSphereStaticIPs ValidatingAdmissionPolicy VolumeGroupSnapshot]
$ oc get crd| grep volumegroupsnapshot
volumegroupsnapshotclasses.groupsnapshot.storage.k8s.io           2024-02-12T15:26:44Z
volumegroupsnapshotcontents.groupsnapshot.storage.k8s.io          2024-02-12T15:26:44Z
volumegroupsnapshots.groupsnapshot.storage.k8s.io                 2024-02-12T15:26:44Z
$ oc get deploy/csi-snapshot-webhook -oyaml| grep 'enable-volume-group'
        - --enable-volume-group-snapshot-webhook
$ oc get deploy/csi-snapshot-controller -oyaml| grep 'enable-volume-group'
        - --enable-volume-group-snapshots

openshift-ci-robot · 2024-02-12T15:57:09Z

@bertinatto: This pull request references STOR-1700 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

Details

In response to this:

CC @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bertinatto · 2024-02-12T15:58:49Z

/label px-approved

bertinatto · 2024-02-12T15:59:16Z

/docs-approved

/label docs-approved

openshift-bot · 2024-02-12T19:20:36Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-csi-snapshot-controller-operator-container-v4.16.0-202402121808.p0.g4b8c056.assembly.stream.el9 for distgit ose-cluster-csi-snapshot-controller-operator.
All builds following this will include this PR.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 1, 2024

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 1, 2024

openshift-ci bot requested review from dobsonj and gnufied February 1, 2024 21:37

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024

bertinatto force-pushed the volumegroupsnapshot branch from d04408e to 9a1645b Compare February 2, 2024 16:35

bertinatto force-pushed the volumegroupsnapshot branch 5 times, most recently from 01e72db to d280da2 Compare February 6, 2024 19:51

Phaow mentioned this pull request Feb 7, 2024

STOR-1700: Rebase external-snapshotter to v7.0.0 to get VolumeGroupSnapshot openshift/csi-external-snapshotter#139

Merged

bertinatto force-pushed the volumegroupsnapshot branch 3 times, most recently from 4324238 to f66d0e9 Compare February 7, 2024 16:52

bertinatto added 2 commits February 7, 2024 15:50

Add ClusterRoles for reading featuregates and clusterversions

b7e46db

bertinatto force-pushed the volumegroupsnapshot branch from f66d0e9 to df63fcd Compare February 7, 2024 18:50

bertinatto changed the title ~~WIP: STOR-1700: Pass VolumeGroupSnapshot argument if feature is enabled~~ STOR-1700: Pass VolumeGroupSnapshot argument if feature is enabled Feb 8, 2024

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2024

bertinatto force-pushed the volumegroupsnapshot branch from df63fcd to ac553fd Compare February 9, 2024 11:02

bertinatto added 2 commits February 9, 2024 08:03

Conditionally create RBACs for VolumeGroupSnapshot resources

0d3d951

go mod vendor

545959d

bertinatto force-pushed the volumegroupsnapshot branch from ac553fd to 545959d Compare February 9, 2024 11:03

openshift-ci bot assigned jsafrane Feb 9, 2024

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Feb 9, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2024

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 12, 2024

openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Feb 12, 2024

openshift-merge-bot bot merged commit 4b8c056 into openshift:master Feb 12, 2024

STOR-1700: Pass VolumeGroupSnapshot argument if feature is enabled #191

STOR-1700: Pass VolumeGroupSnapshot argument if feature is enabled #191

Uh oh!

Conversation

bertinatto commented Feb 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 1, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Feb 1, 2024

Uh oh!

bertinatto commented Feb 2, 2024

Uh oh!

bertinatto commented Feb 5, 2024

Uh oh!

bertinatto commented Feb 5, 2024

Uh oh!

openshift-ci-robot commented Feb 7, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bertinatto commented Feb 8, 2024

Uh oh!

jsafrane commented Feb 9, 2024

Uh oh!

jsafrane commented Feb 9, 2024

Uh oh!

jsafrane commented Feb 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsafrane commented Feb 9, 2024

Uh oh!

bertinatto commented Feb 9, 2024

Uh oh!

openshift-ci bot commented Feb 9, 2024

Uh oh!

lpettyjo commented Feb 12, 2024

Uh oh!

Phaow commented Feb 12, 2024

Uh oh!

openshift-ci-robot commented Feb 12, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bertinatto commented Feb 12, 2024

Uh oh!

bertinatto commented Feb 12, 2024

Uh oh!

openshift-bot commented Feb 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bertinatto commented Feb 1, 2024 •

edited

Loading

openshift-ci-robot commented Feb 1, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Feb 7, 2024 •

edited by openshift-ci bot

Loading

jsafrane commented Feb 9, 2024 •

edited

Loading

openshift-ci-robot commented Feb 12, 2024 •

edited by openshift-ci bot

Loading