Skip to content

Switch API to openshift/api repo #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Mar 7, 2022
Merged

Switch API to openshift/api repo #9

openshift-merge-robot merged 2 commits into from
Mar 7, 2022

Conversation

@JoelSpeed
Copy link
Contributor

@JoelSpeed JoelSpeed commented Mar 7, 2022

This removes the in-repo API and moves over to using the openshift/api version of the API which was recently merged in openshift/api#1112

@JoelSpeed JoelSpeed force-pushed the cpms-openshift-api branch from 0657903 to cc40fe9 Compare March 7, 2022 16:17
damdo
damdo reviewed Mar 7, 2022
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

go.mod
k8s.io/apimachinery v0.23.0
github.com/openshift/api v0.0.0-20220307153316-94bdffb41551
k8s.io/apimachinery v0.23.4
k8s.io/client-go v0.23.0
Copy link
Member

@damdo damdo Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to go with v0.23.4 also here?

Copy link
Contributor Author

@JoelSpeed JoelSpeed Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update this in a later PR

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2022

@JoelSpeed: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-disruptive cc40fe9 link false /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

JoelSpeed
JoelSpeed commented Mar 7, 2022
View reviewed changes
Copy link
Contributor Author

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2022
@openshift-merge-robot openshift-merge-robot merged commit c5d2f02 into openshift:main Mar 7, 2022
@JoelSpeed JoelSpeed deleted the cpms-openshift-api branch March 7, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo damdo left review comments

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

@Fedosin Fedosin Awaiting requested review from Fedosin

Assignees

@damdo damdo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JoelSpeed @damdo @openshift-merge-robot