-
Notifications
You must be signed in to change notification settings - Fork 50
[OCPCLOUD-1586] Update ControlPlaneMachineSet API from openshift/api #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ObservedGeneration: 3, | ||
| Replicas: 5, | ||
| ReadyReplicas: 3, | ||
| UpdatedReplicas: 2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is 3:
id0 - updated (and ready) +1
id1 - the pending one is updated +1
id2 - the pending one is updated +1
This is to be consistent with the status fields
damdo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@JoelSpeed: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This updates the API based on openshift/api#1216.
There were a few changes to the API made within that PR that need to be accounted for here, mainly the changes of the AWS resource reference discriminator values and then some clarification of the status fields