Skip to content

OSASINFRA-3180: openstack: volume type in failure domain#217

Merged
openshift-merge-robot merged 3 commits intoopenshift:mainfrom
shiftstack:openstack_volumetype
Jul 7, 2023
Merged

OSASINFRA-3180: openstack: volume type in failure domain#217
openshift-merge-robot merged 3 commits intoopenshift:mainfrom
shiftstack:openstack_volumetype

Conversation

@pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented Jun 15, 2023 •
edited
Loading

Depends on #195
Depends on openshift/api#1496

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 15, 2023
@pierreprinetti pierreprinetti changed the title openstack: volume type in failure domain OSASINFRA-3180: openstack: volume type in failure domain Jun 15, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 15, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 15, 2023 •
edited by openshift-ci bot
Loading

@pierreprinetti: This pull request references OSASINFRA-3180 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 15, 2023 •
edited by openshift-ci bot
Loading

@pierreprinetti: This pull request references OSASINFRA-3180 which is a valid jira issue.

Details

In response to this:

Depends on #195

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 15, 2023 •
edited by openshift-ci bot
Loading

@pierreprinetti: This pull request references OSASINFRA-3180 which is a valid jira issue.

Details

In response to this:

Depends on #195
Depends on openshift/api#1496

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EmilienM
Copy link
Member

EmilienM commented Jun 15, 2023

Nice start @pierreprinetti - I'm thinking, didn't you have to patch the testutils as well for the tests to cover volumeType?

@pierreprinetti pierreprinetti mentioned this pull request Jun 20, 2023
Merged
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2023
@EmilienM EmilienM mentioned this pull request Jun 30, 2023
Merged
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2023
@pierreprinetti pierreprinetti force-pushed the openstack_volumetype branch from dd84948 to efab8a8 Compare July 4, 2023 14:56
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2023
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 4, 2023
@pierreprinetti pierreprinetti force-pushed the openstack_volumetype branch 2 times, most recently from 433482c to 94bae72 Compare July 4, 2023 16:24
@pierreprinetti pierreprinetti marked this pull request as draft July 4, 2023 17:28
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 4, 2023
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Jul 4, 2023

/test unit

@pierreprinetti pierreprinetti force-pushed the openstack_volumetype branch from 786c294 to 78a7f28 Compare July 4, 2023 18:16
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Jul 4, 2023

/test unit

@EmilienM
Copy link
Member

EmilienM commented Jul 4, 2023

/test unit

@EmilienM EmilienM force-pushed the openstack_volumetype branch from 31cebbb to e49d77f Compare July 5, 2023 16:18
@EmilienM
Copy link
Member

EmilienM commented Jul 5, 2023

/test unit

@EmilienM EmilienM force-pushed the openstack_volumetype branch from e49d77f to 3aa0dd5 Compare July 5, 2023 16:43
@EmilienM
Copy link
Member

EmilienM commented Jul 5, 2023

/test unit lint

@EmilienM
Copy link
Member

EmilienM commented Jul 5, 2023

/test unit
sounds like a flake

@pierreprinetti pierreprinetti force-pushed the openstack_volumetype branch from 3aa0dd5 to 54dcda4 Compare July 6, 2023 13:27
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Jul 6, 2023

/test lint vet unit vendor images generate fmt

@pierreprinetti
Copy link
Member Author

pierreprinetti commented Jul 6, 2023

/test unit

@pierreprinetti
Copy link
Member Author

pierreprinetti commented Jul 6, 2023

/test lint vet unit vendor images generate fmt

@EmilienM
Copy link
Member

EmilienM commented Jul 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2023
@pierreprinetti pierreprinetti marked this pull request as ready for review July 6, 2023 15:22
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2023
@openshift-ci openshift-ci bot requested a review from damdo July 6, 2023 15:24
@EmilienM
Copy link
Member

EmilienM commented Jul 6, 2023

@damdo @odvarkadaniel @JoelSpeed
This one is ready for review.

This should be the last large piece of our work in CCPMSO.

@damdo
Copy link
Member

damdo commented Jul 6, 2023

/test unit

odvarkadaniel
odvarkadaniel reviewed Jul 6, 2023
View reviewed changes
JoelSpeed
JoelSpeed reviewed Jul 6, 2023
View reviewed changes
pierreprinetti and others added 3 commits July 6, 2023 13:36
@pierreprinetti @EmilienM
openstack: Add volume type to the failure domains
75daa13 
Co-Authored-By: Pierre Prinetti <pierreprinetti@redhat.com>
Co-Authored-By: Emilien Macchi <emilien@redhat.com>
@pierreprinetti @EmilienM
Bump testutils
4b5efd3 
Rebase on the last testutils version, which has a nil rootVolume in the
failureDomain fixture for OpenStack.
@pierreprinetti @EmilienM
openstack: Test empty rootVolume
9f1696b 
While not canonical, this configuration should still be accepted by the
controller.
@EmilienM EmilienM force-pushed the openstack_volumetype branch from a8772b4 to 9f1696b Compare July 6, 2023 17:36
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2023
@EmilienM
Copy link
Member

EmilienM commented Jul 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2023
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Jul 7, 2023

/retest
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit 7db52b3 into openshift:main Jul 7, 2023
@pierreprinetti pierreprinetti deleted the openstack_volumetype branch July 7, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@damdo damdo Awaiting requested review from damdo

+2 more reviewers

@EmilienM EmilienM EmilienM left review comments

@odvarkadaniel odvarkadaniel odvarkadaniel left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@EmilienM EmilienM

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pierreprinetti @openshift-ci-robot @EmilienM @damdo @JoelSpeed @odvarkadaniel @openshift-merge-robot