Skip to content

Conversation

@damemi
Copy link
Contributor

@damemi damemi commented Jul 30, 2019

Related to #75, I think it may be a bug that these config changes exist in release-4.1 of the OpenShift API but were not propagated to 4.1 of the config operator. Holding while I look more into this

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1734512

@openshift-ci-robot
Copy link

@damemi: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[wip] missing config updates for infrastructure crd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2019
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 30, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: damemi
To complete the pull request process, please assign deads2k
You can assign the PR to them by writing /assign @deads2k in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

@damemi: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[wip] missing config updates for infrastructure crd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damemi damemi changed the title [wip] missing config updates for infrastructure crd [release-4.1] Bug 1734512: missing config updates for infrastructure crd Jul 30, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2019
@openshift-ci-robot
Copy link

@damemi: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

[release-4.1] Bug 1734512: missing config updates for infrastructure crd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 30, 2019
- package: github.com/openshift/library-go
version: master
- package: github.com/openshift/api
version: dedfb47b1ff14bbd03727fa5720f63d8dc7bea5b
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the exact commit where these changes were added. If I go any further (for example, pinning to release-4.1 explicitly) it will also pull in the apiserver changes in #75

@deads2k
Copy link
Contributor

deads2k commented Jul 30, 2019

pinning to a sha looks wrong. #75 appears to fix two bugzillas. go you

@damemi damemi closed this Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants