Skip to content

add empty CRs #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 2, 2019
Merged

add empty CRs #39

openshift-merge-robot merged 1 commit into from
May 2, 2019

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Apr 11, 2019

from #38

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 11, 2019
@rphillips
Copy link
Contributor

rphillips commented Apr 11, 2019

The error doesn't look like a MCO rendering error... going to...

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Apr 12, 2019

@rphillips it does

                    {
                        "lastTransitionTime": "2019-04-11T19:46:50Z",
                        "message": "Failed to resync 0.0.1-2019-04-11-192548 because: error pool master is not ready, retrying. Status: (total: 3, updated: 0, unavailable: 1)",
                        "reason": "error pool master is not ready, retrying. Status: (total: 3, updated: 0, unavailable: 1)",
                        "status": "True",
                        "type": "Failing"
                    }
                ],

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-config-operator/39/pull-ci-openshift-cluster-config-operator-master-e2e-aws/168/artifacts/e2e-aws/clusteroperators.json

@deads2k
Copy link
Contributor Author

deads2k commented Apr 12, 2019

@rphillips opened https://bugzilla.redhat.com/show_bug.cgi?id=1699353 to help track it.

@deads2k
Copy link
Contributor Author

deads2k commented Apr 15, 2019

/test all

@rphillips
Copy link
Contributor

rphillips commented Apr 15, 2019

/retest

1 similar comment
@rphillips
Copy link
Contributor

rphillips commented Apr 18, 2019

/retest

@rphillips rphillips mentioned this pull request Apr 18, 2019
Merged
@rphillips
Copy link
Contributor

rphillips commented Apr 22, 2019

/retest

1 similar comment
@sjenning
Copy link
Contributor

sjenning commented Apr 23, 2019

/retest

@sjenning
Copy link
Contributor

sjenning commented Apr 23, 2019

This has failed e2e-aws the same way every time

cluster operator machine-config is reporting a failure: Failed to resync 0.0.1-2019-04-15-163916 because: error pool master is not ready, retrying. Status: (total: 3, updated: 0, unavailable: 1): timed out waiting for the condition"

Do we know what is wrong here?

@rphillips
Copy link
Contributor

rphillips commented Apr 23, 2019

I don't think this PR has any chance of succeeding without openshift/machine-config-operator#644

@sjenning
Copy link
Contributor

sjenning commented May 1, 2019

why did the bot close this?

@sjenning sjenning reopened this May 1, 2019
@sjenning
Copy link
Contributor

sjenning commented May 1, 2019

/retest
now that openshift/machine-config-operator#644 is merged

@sjenning
Copy link
Contributor

sjenning commented May 1, 2019

/retest

2 similar comments
@sjenning
Copy link
Contributor

sjenning commented May 1, 2019

/retest

@rphillips
Copy link
Contributor

rphillips commented May 2, 2019

/retest

@rphillips
Copy link
Contributor

rphillips commented May 2, 2019 •
edited
Loading

@deads2k all tests pass... ready to rock 'n roll 🎸

@sjenning
Copy link
Contributor

sjenning commented May 2, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented May 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented May 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f094c3b into openshift:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@sttts sttts Awaiting requested review from sttts

Assignees

@sjenning sjenning

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@deads2k @rphillips @sjenning @openshift-ci-robot @openshift-bot @openshift-merge-robot