Skip to content

Comments

SPLAT-1127: bring in vSphere CPMSO API updates#342

Merged
openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
rvanderp3:cpms-vsphere-failure-domain
Oct 26, 2023
Merged

SPLAT-1127: bring in vSphere CPMSO API updates#342
openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
rvanderp3:cpms-vsphere-failure-domain

Conversation

@rvanderp3
Copy link
Contributor

@rvanderp3 rvanderp3 commented Aug 14, 2023

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 14, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 14, 2023 •
edited by openshift-ci bot
Loading

@rvanderp3: This pull request references SPLAT-1127 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rvanderp3 rvanderp3 changed the title SPLAT-1127: extend API to enable vSphere control plane machineset WIP: SPLAT-1127: extend API to enable vSphere control plane machineset Aug 14, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2023
@openshift-ci openshift-ci bot requested review from deads2k and tkashem August 14, 2023 17:26
@rvanderp3 rvanderp3 marked this pull request as draft August 14, 2023 17:26
@rvanderp3
Copy link
Contributor Author

rvanderp3 commented Aug 14, 2023

/uncc @deads2k @tkashem

@openshift-ci openshift-ci bot removed request for deads2k and tkashem August 14, 2023 17:27
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch from 9a4d1b8 to 83f7242 Compare August 15, 2023 17:34
@rvanderp3
Copy link
Contributor Author

rvanderp3 commented Aug 15, 2023

/refresh

@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch from 83f7242 to 3a08f24 Compare August 15, 2023 17:52
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2023
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch 4 times, most recently from d71531e to 25a2cb4 Compare August 25, 2023 19:40
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2023
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch 2 times, most recently from ba24690 to 07db5e6 Compare August 28, 2023 21:04
@rvanderp3 rvanderp3 mentioned this pull request Sep 12, 2023
Merged
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch from 07db5e6 to bb3a106 Compare September 19, 2023 17:34
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch from bb3a106 to 4b68547 Compare October 3, 2023 17:21
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 3, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 3, 2023 •
edited by openshift-ci bot
Loading

@rvanderp3: This pull request references SPLAT-1127 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch 2 times, most recently from c28628e to 88bd2c6 Compare October 3, 2023 17:39
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 3, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 3, 2023 •
edited by openshift-ci bot
Loading

@rvanderp3: This pull request references SPLAT-1127 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch 3 times, most recently from 25a5d71 to 6c4dfbb Compare October 18, 2023 20:23
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch from 6c4dfbb to 21571c7 Compare October 23, 2023 19:46
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch from 21571c7 to 88c0bb1 Compare October 24, 2023 22:45
@rvanderp3 rvanderp3 changed the title WIP: SPLAT-1127: extend API to enable vSphere control plane machineset SPLAT-1127: bring in vSphere CPMSO API updates Oct 24, 2023
@rvanderp3 rvanderp3 marked this pull request as ready for review October 24, 2023 22:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2023
@openshift-ci openshift-ci bot requested review from soltysh and tkashem October 24, 2023 22:47
@mtulio
Copy link

mtulio commented Oct 24, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2023
@faermanj
Copy link

faermanj commented Oct 25, 2023

/lgtm

@rvanderp3
Copy link
Contributor Author

rvanderp3 commented Oct 25, 2023

/test e2e-aws-serial

@rvanderp3
Copy link
Contributor Author

rvanderp3 commented Oct 25, 2023

/assign @deads2k

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2023

@rvanderp3: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rvanderp3 rvanderp3 mentioned this pull request Oct 25, 2023
Merged
6 tasks
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 26, 2023

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: faermanj, JoelSpeed, mtulio, rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2023
@openshift-ci openshift-ci bot merged commit 1b6bf28 into openshift:master Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soltysh soltysh Awaiting requested review from soltysh

@tkashem tkashem Awaiting requested review from tkashem

Assignees

@faermanj faermanj

@mtulio mtulio

@deads2k deads2k

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rvanderp3 @openshift-ci-robot @mtulio @faermanj @JoelSpeed @deads2k @openshift-merge-robot