NE-975: Update openshift/api for updated ingress config loadBalancer fields#268
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Oct 13, 2022
Merged
Conversation
Miciah
reviewed
Oct 12, 2022
| domain: | ||
| description: "domain is used to generate a default host name for a route when the route's host name is empty. The generated host name will follow this pattern: \"<route-name>.<route-namespace>.<domain>\". \n It is also used as the default wildcard domain suffix for ingress. The default ingresscontroller domain will follow this pattern: \"*.<domain>\". \n Once set, changing domain is not currently supported." | ||
| type: string | ||
| loadbalancer: |
gcs278
force-pushed
the
bump-openshift-api-lbtype
branch
from
e227a10 to
a759532
Compare
|
/lgtm |
Contributor
Author
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
gcs278
force-pushed
the
bump-openshift-api-lbtype
branch
from
a759532 to
fca9956
Compare
|
/lgtm |
Contributor
|
@gcs278: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
Author
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, gcs278, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For NE-975, we need the
ingress.config.openshift.ioCRD to have the loadBalancer field for specifying loadBalancer type upon installation. See openshift/api#1209, openshift/cluster-ingress-operator#837, and openshift/installer#6478go.mod: Bumped openshift/api tov0.0.0-20220927015011-24ee13c10f3band also bumped k8s modules to0.25.2due to dependency issues (make verifywas failing with K8S module conflicts). I also weirdly had to addk8s.io/apiserver v0.25.2to required,go mod tidyandgo mod vendorin order to resolve apiserver related issues. But thengo mod tidyremoved it from therequiresection, but the indirect dependency is now 0.25.0. Not sure what was going on.CC: @miheer @Miciah