Skip to content

CNF-7382: feat: update to latest openshift/api#265

Closed
eggfoobar wants to merge 1 commit intoopenshift:masterfrom
eggfoobar:update_openshift_api
Closed

CNF-7382: feat: update to latest openshift/api#265
eggfoobar wants to merge 1 commit intoopenshift:masterfrom
eggfoobar:update_openshift_api

Conversation

@eggfoobar
Copy link
Contributor

@eggfoobar eggfoobar commented Sep 8, 2022

Signed-off-by: ehila ehila@redhat.com

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2022
@openshift-ci openshift-ci bot requested review from mfojtik and tkashem September 8, 2022 02:18
@eggfoobar eggfoobar force-pushed the update_openshift_api branch from 9c91a36 to 5586ffc Compare October 19, 2022 16:10
@eggfoobar eggfoobar force-pushed the update_openshift_api branch from 5586ffc to 3891805 Compare December 6, 2022 20:23
@eggfoobar eggfoobar force-pushed the update_openshift_api branch from 3891805 to 845ab69 Compare February 1, 2023 06:49
@eggfoobar
update openshift/api to latest for CPUPartitioning
51c612c 
Signed-off-by: ehila <ehila@redhat.com>
@eggfoobar eggfoobar force-pushed the update_openshift_api branch from 845ab69 to 51c612c Compare February 8, 2023 22:17
@eggfoobar eggfoobar changed the title WIP: feat: update to latest openshift/api feat: update to latest openshift/api Feb 9, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2023

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@eggfoobar
Copy link
Contributor Author

eggfoobar commented Feb 9, 2023

/assign @tkashem

This PR updates go.mod openshift/api to the latest to make use of CPUPartitioning API openshift/api#1284

@eggfoobar eggfoobar changed the title feat: update to latest openshift/api CNF-7382: feat: update to latest openshift/api Feb 9, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 9, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 9, 2023 •
edited by openshift-ci bot
Loading

@eggfoobar: This pull request references CNF-7382 which is a valid jira issue.

Details

In response to this:

Signed-off-by: ehila ehila@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tkashem
Copy link
Contributor

tkashem commented Feb 9, 2023

/lgtm
/approve

/hold
(if you need to hold it until o/k pr is tagged and ready to merge, feel free to cancel the hold when you think it can merge)

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Feb 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2023
@eggfoobar
Copy link
Contributor Author

eggfoobar commented Feb 9, 2023

#278 Updated to latest which includes the updated CR needed by this PR, closing.

@eggfoobar eggfoobar closed this Feb 9, 2023
@eggfoobar eggfoobar deleted the update_openshift_api branch March 5, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@tkashem tkashem Awaiting requested review from tkashem

Assignees

@tkashem tkashem

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eggfoobar @openshift-ci-robot @tkashem